Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements for edit offer #1521

Merged
merged 6 commits into from
Apr 27, 2018
Merged

Improvements for edit offer #1521

merged 6 commits into from
Apr 27, 2018

Conversation

ripcurlx
Copy link
Contributor

@ripcurlx ripcurlx commented Apr 26, 2018 •
edited
Loading

@ripcurlx ripcurlx requested a review from ManfredKarrer April 26, 2018 09:11
ManfredKarrer
ManfredKarrer suggested changes Apr 26, 2018
View reviewed changes
Copy link
Contributor

@ManfredKarrer ManfredKarrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far I tested. Only small thing is that the title in the box "Set amount and price" is not correct anymore as we don't allow editing amount.

@ripcurlx
Copy link
Contributor Author

@ManfredKarrer please merge bisq-network/bisq-core#102 for new translations

ManfredKarrer
ManfredKarrer approved these changes Apr 27, 2018
View reviewed changes
Copy link
Contributor

@ManfredKarrer ManfredKarrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ManfredKarrer ManfredKarrer merged commit 0a6f79b into bisq-network:master Apr 27, 2018
@ManfredKarrer
Copy link
Contributor

Actually it was tested, just last commit was untested....

@ripcurlx ripcurlx mentioned this pull request May 29, 2018
Closed
@ripcurlx ripcurlx deleted the improve-edit-offer branch September 5, 2018 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManfredKarrer ManfredKarrer ManfredKarrer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ripcurlx @ManfredKarrer