Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vote result update issue #3269

Closed
chimp1984 opened this issue Sep 16, 2019 · 0 comments · Fixed by #3356
Closed

Vote result update issue #3269

chimp1984 opened this issue Sep 16, 2019 · 0 comments · Fixed by #3356
Labels
good first issue in:gui

Comments

@chimp1984
Copy link
Contributor

If one selects a cycle in vote result the proposals are listed below the cycle table. After switching to another screen and getting back the same syvle stays selected but the proposal table is not displayed. After switching another cycle and getting back the proposal table is visible again.
Expected behaviour. Last selected cycle triggers also display of proposals.
stejbac added a commit to stejbac/bisq that referenced this issue Oct 3, 2019
@stejbac
Fix proposal table hide when switching to another screen and back
f5d2493 
Do not remove the proposals table when VoteResultView is deactivated, as
the cycle selection which triggered its display is still active upon
switching to another screen and back again. This fixes bisq-network#3269.

Also remove a spurious 'GUIUtil.removeChildrenFromGridPaneRows' call
when a proposal result is selected, as it is no longer needed since
switching from an inline votes table to a popup.
@stejbac stejbac mentioned this issue Oct 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue in:gui
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix proposal table hide when switching to another screen and back stejbac/bisq
2 participants
@freimair @chimp1984