Merge pull request #5374 from cd2357/mathutils-test

Handle rounding of infinite Doubles
bisq-network · Apr 13, 2021 · e516992 · e516992
2 parents ca2731e + 5e73774
commit e516992
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/common/src/main/java/bisq/common/util/MathUtils.java b/common/src/main/java/bisq/common/util/MathUtils.java
@@ -42,6 +42,8 @@ public static double roundDouble(double value, int precision) {
     public static double roundDouble(double value, int precision, RoundingMode roundingMode) {
         if (precision < 0)
             throw new IllegalArgumentException();
+        if (!Double.isFinite(value))
+            throw new IllegalArgumentException("Expected a finite double, but found " + value);
 
         try {
             BigDecimal bd = BigDecimal.valueOf(value);

diff --git a/common/src/test/java/bisq/common/util/MathUtilsTest.java b/common/src/test/java/bisq/common/util/MathUtilsTest.java
@@ -24,6 +24,20 @@
 
 public class MathUtilsTest {
 
+    @Test(expected = IllegalArgumentException.class)
+    public void testRoundDoubleWithInfiniteArg() {
+        MathUtils.roundDouble(Double.POSITIVE_INFINITY, 2);
+    }
+
+    @Test(expected = IllegalArgumentException.class)
+    public void testRoundDoubleWithNaNArg() {
+        MathUtils.roundDouble(Double.NaN, 2);
+    }
+
+    @Test(expected = IllegalArgumentException.class)
+    public void testRoundDoubleWithNegativePrecision() {
+        MathUtils.roundDouble(3, -1);
+    }
 
     @SuppressWarnings("OptionalGetWithoutIsPresent")
     @Test