Add outdated_translation variable #220

huey735 · 2019-08-26T17:46:00Z

On @m52go's advice I changed the construction of the outdated
translation alert tool to be spefic to the page instead of
the language. I added a "outdated_translation" variable to
the front matter of the relevant translated pages. They'll
have the values 'true' or 'false' according to the state.

@m52go

On @m52go's advice I changed the construction of the outdated translation alert tool to be spefic to the page instead of the language. I added a "outdated_translation" variable to the front matter of the relevant translated pages. They'll have the values 'true' or 'false' according to the state.

m52go · 2019-08-26T17:56:42Z

Thanks Huey -- much better PR.

Another thing we need to make sure to test is how the site appears on mobile, since the whole site is built to be responsive.

Making the font smaller won't work...we need to figure something else out.

erciccione · 2019-08-26T22:11:34Z

_includes/main_nav_tr.html

+
+     <!-- Outdated translation alert tool tag-->
+     {% if page.outdated_translation %}
+       <span class="navbar-text" style="color: orange;">Outdated translation</span>


I suggest to add a link toTransifex, so that potential contributors know where to go if they want to help translate the page. The message could be something like Outdated translation - [Help us to improve it!](https://www.transifex.com/bisq/bisq-website/).

Would be also cool to have the phrase translatable imho, so that when somebody is using another language the warning will be in their language.

@erciccione what do you mean by message?

The content of the warning (that now is only Outdated translation)

Well, for that I think we'll have to move it from the navbar. There's not enough space there as it is.

I don't think the navbar is the best place for that warning. I would put it in a dedicated snippet under the navbar. That way would be easier to see for the user, we would have more space so we can be more descriptive and styling form mobile would be easier to manage.

@erciccione how about this, following the standard warning sign palette. Orange text on green background doesn't stand out that much.

The black text however doesn't imply that there's an hyperlink to be clicked.

I'm not great with colours so, keep that in mind :P, but i personally think this solution is better than simple text. What about having the hyperlink underlined? or underlined on hover?

@ericcione now it looks like this when hovered

I guess could be fine. Better wait @m52go's input on this

m52go · 2019-09-03T12:58:59Z

Now I'm kind of debating the need for this mechanism in the first place. The website isn't updated that often.

Major updates we should mostly know ahead of time and can plan to get the necessary translations ahead of time.

Minor updates probably don't justify having a page-wide flag...it's not that helpful to the user anyway because they won't know what's up-to-date and what's not.

huey735 · 2019-09-03T20:03:25Z

@m52go I still support this tool or some version of it.
In my mind the flag is to let the user know that they should refer to the English version for the up to date info. It also works as an ad to translators.

Move outdated_translation tool from _includes/main_nav_tr.html to _layouts/page.html.

m52go · 2019-09-04T02:20:15Z

I am in favor of showing a message to encourage translators to contribute updates.

In that case, maybe it would be better to put a more subtle message toward the bottom (right above the site footer at the bottom of the page content) saying something to the effect "This translation is slightly out-of-date. Would you like to help?"

erciccione · 2019-09-04T08:34:00Z

I wouldn't put it at the bottom. Users need to know if a document is up to date before they start reading it. That's better UX.

I would keep the warning at the top under the navbar, but i would make it more visible. Maybe i light green background?

Changed the text color to black and background-color to orange. And on hover the text-decoration is underline and the color is blue.

m52go · 2019-09-04T17:21:28Z

Could we do something a little more elegant? I don't think the current proposal goes well with the site's aesthetic.

For example:

huey735 · 2019-09-04T20:11:42Z

@m52go Am I right in assuming that that warning sign at the beginning of the sentence is the unicide U+26A0 and not an image?

m52go · 2019-09-04T20:21:17Z

Yes. This is exactly what I put in the if condition. Don't need any additional CSS either.

<p class="text-muted">⚠ This page contains some outdated translations. Help us improve <a href="https://www.transifex.com/bisq/bisq-website/">here</a>!</p>

huey735 · 2019-09-04T22:28:10Z

@m52go Cool, I had come down to something similar. Had span instead of p though.

m52go

This looks ready to go, thanks! Just one small question (see comment).

_includes/main_nav_tr.html

m52go · 2019-09-04T23:02:00Z

Notes:

the outdated_translation variables need to be added to the French pages, but this doesn't need to be done immediately (in this commit) as having no value is also falsey (which results in desired behavior)
with erciccione's Refactored "Statistics" page to make it more i18n friendly #221 merged, we should be able to get rid of the flag on all stats pages

m52go · 2019-09-05T12:24:25Z

ACK

wiz · 2019-09-05T21:33:58Z

_layouts/page.html

+      <!-- Outdated translation alert tool tag-->
+      <div class="col-md-12 order-md-1 text-md-left">
+        {% if page.outdated_translation %}
+          <p class="text-muted">⚠ This page contains some outdated translations. Help us improve <a href="https://www.transifex.com/bisq/bisq-website/">here</a>!</p>


Don't make links like this:
Click here for more information
Make links like this:
More information

huey735 mentioned this pull request Aug 26, 2019

Remove version variable from downloads page #218

Closed

erciccione reviewed Aug 26, 2019

View reviewed changes

m52go mentioned this pull request Aug 29, 2019

Add French translation #223

Merged

Deplace outdated_translation variable

f9c1a1b

Move outdated_translation tool from _includes/main_nav_tr.html to _layouts/page.html.

Make warning text more visible

a94d441

Changed the text color to black and background-color to orange. And on hover the text-decoration is underline and the color is blue.

Make warning text fit the website theme

21d8224

m52go reviewed Sep 4, 2019

View reviewed changes

_includes/main_nav_tr.html Outdated Show resolved Hide resolved

Remove unnecessary div

71a2f09

m52go merged commit 4ea9d82 into bisq-network:master Sep 5, 2019

wiz reviewed Sep 5, 2019

View reviewed changes

huey735 deleted the addOutdatedTranslationVariable branch September 8, 2019 15:28

This was referenced Sep 8, 2019

Edit Outdated_Translation tool text #237

Merged

For Cycle 5 bisq-network/compensation#340

Closed

erciccione mentioned this pull request Sep 9, 2019

For Cycle 5 bisq-network/compensation#358

Closed

m52go mentioned this pull request Sep 9, 2019

For Cycle 5 bisq-network/compensation#361

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add outdated_translation variable #220

Add outdated_translation variable #220

huey735 commented Aug 26, 2019

m52go commented Aug 26, 2019

erciccione Aug 26, 2019

huey735 Aug 28, 2019

erciccione Aug 29, 2019

huey735 Aug 29, 2019

erciccione Aug 29, 2019

huey735 Sep 4, 2019

huey735 Sep 4, 2019

erciccione Sep 4, 2019

huey735 Sep 4, 2019 •

edited

Loading

erciccione Sep 4, 2019

m52go commented Sep 3, 2019

huey735 commented Sep 3, 2019

m52go commented Sep 4, 2019

erciccione commented Sep 4, 2019

m52go commented Sep 4, 2019

huey735 commented Sep 4, 2019

m52go commented Sep 4, 2019 •

edited

Loading

huey735 commented Sep 4, 2019 •

edited

Loading

m52go left a comment •

edited

Loading

m52go commented Sep 4, 2019

m52go commented Sep 5, 2019

wiz Sep 5, 2019

Add outdated_translation variable #220

Add outdated_translation variable #220

Conversation

huey735 commented Aug 26, 2019

m52go commented Aug 26, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

huey735 Sep 4, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

m52go commented Sep 3, 2019

huey735 commented Sep 3, 2019

m52go commented Sep 4, 2019

erciccione commented Sep 4, 2019

m52go commented Sep 4, 2019

huey735 commented Sep 4, 2019

m52go commented Sep 4, 2019 • edited Loading

huey735 commented Sep 4, 2019 • edited Loading

m52go left a comment • edited Loading

Choose a reason for hiding this comment

m52go commented Sep 4, 2019

m52go commented Sep 5, 2019

Choose a reason for hiding this comment

huey735 Sep 4, 2019 •

edited

Loading

m52go commented Sep 4, 2019 •

edited

Loading

huey735 commented Sep 4, 2019 •

edited

Loading

m52go left a comment •

edited

Loading