Skip to content
This repository has been archived by the owner on Jun 15, 2021. It is now read-only.

Add doc on account signing #173

Merged
merged 5 commits into from
Oct 29, 2019
Merged

Conversation

m52go
Copy link
Contributor

@m52go m52go commented Oct 27, 2019

I also included basic information on payment accounts, but can take it out if there's anything that needs more review and back-and-forth.

I got risky payment account information from here (i.e., which are and which aren't):
https://github.com/bisq-network/bisq/blob/13f00a9f48ef9e23a5cb54cf062913e9d1b220cf/core/src/main/java/bisq/core/payment/payload/PaymentMethod.java#L333

@m52go m52go requested review from ripcurlx and sqrrm October 27, 2019 21:28
Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK (links not tested)

Some comments but nothing that necessarily needs changing


There are several payment methods you can use to buy and sell bitcoin with Bisq. This doc covers the details and limitations of each.

Every offer on Bisq designates a payment method for traders to settle payments. The Bisq software does not actually integrate with any payment methods—all non-bitcoin fund transfers are made outside of the Bisq software.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not exactly true since BSQ are also done in-client, although it's not automated and not integrated, might not be worth mentioning.

@m52go
Copy link
Contributor Author

m52go commented Oct 28, 2019

@sqrrm thanks for the quick review...I've made it more obvious that limits apply to buying not selling.

After reading over again I added a small bit on plain account aging, as it was mentioned but never explained, and new users probably won't understand the difference unless it's spelled out clearly.

Also add admonition on account aging.
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACK - please see my comments

|{very-low-risk}
|Not available in the USA

|Alipay
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no account signing necessary

|{low-risk}
|

|Faster Payments
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no account signing necessary

|{high-risk}
|

|HalCash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no account signing necessary

|{high-risk}
|

|Japan Zengin Furikomi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no account signing necessary

|{high-risk}
|

|Perfect Money
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no account signing necessary

|{high-risk}
|

|PromptPay
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no account signing necessary

|{high-risk}
|

|Swish
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no account signing necessary

|{high-risk}
|

|WeChat Pay
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no account signing necessary

@m52go m52go merged commit c76eb74 into bisq-network:master Oct 29, 2019
@m52go m52go deleted the account-signing-doc branch October 29, 2019 17:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants