Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installer: add support for default configurations #203

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

KanjiMonster
Copy link
Contributor

Add support for creating a default network config during installation.

By setting the environment variable BISDN_DEFAULT_CONFIG, the identically named example configuration shipped by the baseboxd package will be installed.

This will disable the take over of any configuration from a previous installation, to avoid configuration conflicts.

As a special keyword, 'none' is accepted as a way to prevent configuration backup without creating a default configuration.

@KanjiMonster
Copy link
Contributor Author

Completely untested.

Open question: should specifying a non-existing default config result in a wiped config, or should it then restore the previous installation's one?

I for now opted for the former, since the behavior would be most similar to when setting it to an existing config.

should work this way:

$ BISDN_DEFAULT_CONFIG="foo" onie-nos-install ...

@KanjiMonster KanjiMonster force-pushed the jogo_installer_default_config branch from 955eeae to 3b4ea32 Compare May 31, 2024 10:24
@KanjiMonster KanjiMonster marked this pull request as ready for review May 31, 2024 11:31
@KanjiMonster KanjiMonster requested a review from rubensfig May 31, 2024 11:31
@KanjiMonster KanjiMonster force-pushed the jogo_installer_default_config branch from 3b4ea32 to 606d906 Compare June 4, 2024 10:16
Add support for creating a default network config during installation.

By setting the environment variable BISDN_DEFAULT_CONFIG, the
identically named example configuration shipped by the baseboxd package
will be installed.

This will disable the take over of any configuration from a previous
installation, to avoid configuration conflicts.

As a special keyword, 'none' is accepted as a way to prevent
configuration backup without creating a default configuration.

Signed-off-by: Jonas Gorski <[email protected]>
@KanjiMonster KanjiMonster force-pushed the jogo_installer_default_config branch from 606d906 to a579555 Compare June 4, 2024 10:16
@rubensfig rubensfig merged commit ffcef1c into main Jun 7, 2024
@rubensfig rubensfig deleted the jogo_installer_default_config branch June 7, 2024 08:40
rubensfig added a commit to bisdn/bisdn.github.io that referenced this pull request Jun 7, 2024
Document bisdn/meta-bisdn-linux/pull/203 functionality to provide default
installation of l2 functionality.

Signed-off-by: Rubens Figueiredo <[email protected]>
rubensfig added a commit to bisdn/bisdn.github.io that referenced this pull request Jun 14, 2024
Document bisdn/meta-bisdn-linux/pull/203 functionality to provide default
installation of l2 functionality.

Signed-off-by: Rubens Figueiredo <[email protected]>
rubensfig added a commit to bisdn/bisdn.github.io that referenced this pull request Jun 14, 2024
Document bisdn/meta-bisdn-linux/pull/203 functionality to provide default
installation of l2 functionality.

Signed-off-by: Rubens Figueiredo <[email protected]>
rubensfig added a commit to bisdn/bisdn.github.io that referenced this pull request Jun 18, 2024
Document bisdn/meta-bisdn-linux/pull/203 functionality to provide default
installation of l2 functionality.

Signed-off-by: Rubens Figueiredo <[email protected]>
Co-authored-by: ideaship <[email protected]>
rubensfig added a commit to bisdn/bisdn.github.io that referenced this pull request Jun 18, 2024
Document bisdn/meta-bisdn-linux/pull/203 functionality to provide default
installation of l2 functionality.

Signed-off-by: Rubens Figueiredo <[email protected]>
Co-authored-by: ideaship <[email protected]>
Co-authored-by: Jonas Gorski <[email protected]>
rubensfig added a commit to bisdn/bisdn.github.io that referenced this pull request Jun 19, 2024
Document bisdn/meta-bisdn-linux/pull/203 functionality to provide default
installation of l2 functionality.

Signed-off-by: Rubens Figueiredo <[email protected]>
Co-authored-by: ideaship <[email protected]>
Co-authored-by: Jonas Gorski <[email protected]>

Update platform_configuration/default_installer.md

Co-authored-by: Jonas Gorski <[email protected]>
rubensfig added a commit to bisdn/bisdn.github.io that referenced this pull request Jul 4, 2024
Document bisdn/meta-bisdn-linux/pull/203 functionality to provide default
installation of l2 functionality.

Signed-off-by: Rubens Figueiredo <[email protected]>
Co-authored-by: ideaship <[email protected]>
Co-authored-by: Jonas Gorski <[email protected]>

Update platform_configuration/default_installer.md

Co-authored-by: Jonas Gorski <[email protected]>
rubensfig added a commit to bisdn/bisdn.github.io that referenced this pull request Jul 9, 2024
Document bisdn/meta-bisdn-linux/pull/203 functionality to provide default
installation of l2 functionality.

Signed-off-by: Rubens Figueiredo <[email protected]>
Co-authored-by: ideaship <[email protected]>
Co-authored-by: Jonas Gorski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants