Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VtlEngine dependency and Syntax validation on VTL Artefacts #230

Draft
wants to merge 9 commits into
base: develop
Choose a base branch
from
Draft

Add VtlEngine dependency and Syntax validation on VTL Artefacts #230

wants to merge 9 commits into from

Conversation

jfrancma
Copy link

  • Add post_init validations in Ruleset, UserDefinedOperator and Transformation.
  • Create the generate_vtl_script method that generates a string with all Rulesets, UserDefinedOperators and Transformations.
  • Create tests for post_init validations and generate_vtl_scripts
  • change vtl samples jsons to work with pot_init validations

@jfrancma jfrancma requested a review from javihern98 February 19, 2025 18:06
@jfrancma jfrancma self-assigned this Feb 19, 2025
@jfrancma jfrancma linked an issue Feb 19, 2025 that may be closed by this pull request
Add VtlEngine dependency and Syntax validation on VTL Artefacts #210
Open
javihern98
javihern98 reviewed Feb 19, 2025
View reviewed changes
Copy link
Contributor

@javihern98 javihern98 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to make some minor changes to ensure checks are correct. Remember as well to update the branch using the below button

tests/model/test_vtl.py Outdated
user_defined_operator_schemes=[userdefinedoperatorscheme],
)

transformationscheme.generate_vtl_script()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to make assertions on this tests. Maybe add a vtl file on samples and check the content to it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a sample file for the assertion and add assertion to the test

@javihern98 javihern98 marked this pull request as draft February 20, 2025 10:52
@jfrancma jfrancma marked this pull request as ready for review February 20, 2025 13:15
@javihern98 javihern98 marked this pull request as draft February 20, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javihern98 javihern98 javihern98 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@jfrancma jfrancma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add VtlEngine dependency and Syntax validation on VTL Artefacts
2 participants
@jfrancma @javihern98