moved tracing to Connection. Removed from Database/Driver

birschick-bq · Nov 8, 2024 · 4af814a · 4af814a
1 parent 49f9a72
commit 4af814a
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 9 deletions.
diff --git a/csharp/src/Drivers/Apache/Hive2/HiveServer2Connection.cs b/csharp/src/Drivers/Apache/Hive2/HiveServer2Connection.cs
@@ -252,6 +252,6 @@ private Task DequeueAndWrite(string state)
 
         private Activity? StartActivity(string methodName) => StartActivity(ActivitySource, methodName);
 
-        private static Activity? StartActivity(ActivitySource? activitySource, string methodName) => activitySource?.StartActivity(typeof(HiveServer2Connection).FullName + "." + methodName, parentId: "");
+        private static Activity? StartActivity(ActivitySource? activitySource, string methodName) => activitySource?.StartActivity(typeof(HiveServer2Connection).FullName + "." + methodName);
     }
 }
diff --git a/csharp/src/Drivers/Apache/Spark/SparkDatabase.cs b/csharp/src/Drivers/Apache/Spark/SparkDatabase.cs
@@ -17,9 +17,7 @@
 
 using System;
 using System.Collections.Generic;
-using System.Diagnostics;
 using System.Linq;
-using System.Runtime.CompilerServices;
 
 namespace Apache.Arrow.Adbc.Drivers.Apache.Spark
 {
@@ -41,9 +39,7 @@ public override AdbcConnection Connect(IReadOnlyDictionary<string, string>? opti
                     .Concat(properties.Where(x => !options.Keys.Contains(x.Key, StringComparer.OrdinalIgnoreCase)))
                     .ToDictionary(kvp => kvp.Key, kvp => kvp.Value);
             SparkConnection connection = SparkConnectionFactory.NewConnection(mergedProperties);
-
             connection.OpenAsync().Wait();
-
             return connection;
         }
     }

diff --git a/csharp/src/Drivers/Apache/Spark/SparkDriver.cs b/csharp/src/Drivers/Apache/Spark/SparkDriver.cs
@@ -15,11 +15,7 @@
 * limitations under the License.
 */
 
-using System;
 using System.Collections.Generic;
-using System.Diagnostics;
-using System.Reflection;
-using System.Text.Json;
 
 namespace Apache.Arrow.Adbc.Drivers.Apache.Spark
 {