Fix touch not triggering the popup when body is unavailable during init
#2014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lickTracker` Updated `TouchClickTracker` to register the click handler from `onTouchStart()`, addressing cases where the tracker is initialized before the body is available, improving touch interaction reliability.
maiself
force-pushed
the
fix-touch-click-event
branch
from
bd148d4 to
7942da5
Compare
|
Thank you! This looks great! |
|
@all-contributors add @maiself for code |
|
I've put up a pull request to add @maiself! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frequently the extension would have had to been disabled and re-enabled on mobile for taps to trigger the popup, this change is intended improve touch interaction reliability.