fix: fix tab manager initialization race condition #1492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
STR: 1. Start the add-on but don't enable it 2. Wait for the download to finish 3. Terminate the background process from about:debugging (or just wait for it to terminate) 4. On any regular Web page, enable the add-on by clicking the icon on the toolbar Expected results: The add-on is enabled immediately. Actual results: It takes two clicks. Analysis: We'd hit a race condition where we'd call tabManager.init() while the tabManager was still being initialized. As a result it would update its this.enabled member to `true` but then the initialization steps would reset it back to false. The fix is just to wait for the initialization to complete before trying to toggle the value. As far as I can tell this does not affect the ActiveTabManager because its initialization is synchronous. Fixes #1491.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STR:
for it to terminate)
toolbar
Expected results:
The add-on is enabled immediately.
Actual results:
It takes two clicks.
Analysis:
We'd hit a race condition where we'd call tabManager.init() while the
tabManager was still being initialized. As a result it would update its
this.enabled member to
truebut then the initialization steps wouldreset it back to false.
The fix is just to wait for the initialization to complete before trying
to toggle the value.
As far as I can tell this does not affect the ActiveTabManager because
its initialization is synchronous.
Fixes #1491.