Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme with higher contrast please #692

Closed
afgks opened this issue Jul 22, 2021 · 13 comments
Closed

Dark theme with higher contrast please #692

afgks opened this issue Jul 22, 2021 · 13 comments

Comments

@afgks
Copy link

afgks commented Jul 22, 2021

I dislike the new dark theme. The contrast is too low compared with what I am used to. Could you add the old dark theme back please?

@maekii
Copy link

maekii commented Jul 22, 2021

Yeah, I came here to ask the same thing. Older dark theme was a lot easier on the eyes and blended better with my browser theme.

@birtles
Copy link
Member

birtles commented Jul 22, 2021

Thanks for the feedback! That's good to know. Let me try tweaking it tomorrow.

Thanks again!

@birtles
Copy link
Member

birtles commented Jul 23, 2021

Prior to changing the colours:

image

After changing the colours:

image

Proposed update:

image

@birtles
Copy link
Member

birtles commented Jul 23, 2021

For me the update is a little too "neon" but I don't regularly use dark mode so I'm not sure. It looks like dark mode users tend to prefer very high contrast so maybe it's ok?

birtles added a commit that referenced this issue Jul 23, 2021
@birtles
Copy link
Member

birtles commented Jul 23, 2021

I'm going to go ahead and release this for now. We can tweak it again if there is more feedback.

@birtles
Copy link
Member

birtles commented Jul 23, 2021

This is now released as version 1.1.4.

I've only released on Firefox for now simply because it's faster and easier than the other platforms. I'll wait to address some of the other regressions before re-releasing on the other platforms.

@birtles
Copy link
Member

birtles commented Jul 23, 2021

I'm closing this issue but please feel free to leave feedback here, positive or negative. I'm more than happy to re-open this.

@birtles birtles closed this as completed Jul 23, 2021
@afgks
Copy link
Author

afgks commented Jul 23, 2021

Hello, I used photoshop to adjust the colour of background to #141211, entries to #6f6ff6 #4e4e8b, readings to #69c86b #467846, notes (abbrev, proverb, idiomatic, archaism etc) to #474186.
I think this looks much better:
10t

@birtles
Copy link
Member

birtles commented Jul 24, 2021

Hello, I used photoshop to adjust the colour of background to #141211, entries to #6f6ff6 #4e4e8b, readings to #69c86b #467846, notes (abbrev, proverb, idiomatic, archaism etc) to #474186.

Thank you so much for doing this and even for providing the specific hex codes!

I'm curious about the purple colour. I've gone with blue because it is one of the 10ten brand colours and it is also the highlight colour used in Firefox's dark theme:

image

Is there a reason to prefer purple?

I've also gone with #1d1a19 for the black since that is also one of the 10ten brand colours although it's not overly different to #141211.

I agree the part-of-speech label colours could use some tweaking however.

@afgks
Copy link
Author

afgks commented Jul 24, 2021

Hello, I used photoshop to adjust the colour of background to #141211, entries to #6f6ff6 #4e4e8b, readings to #69c86b #467846, notes (abbrev, proverb, idiomatic, archaism etc) to #474186.

Thank you so much for doing this and even for providing the specific hex codes!

I'm curious about the purple colour. I've gone with blue because it is one of the 10ten brand colours and it is also the highlight colour used in Firefox's dark theme:

image

Is there a reason to prefer purple?

I've also gone with #1d1a19 for the black since that is also one of the 10ten brand colours although it's not overly different to #141211.

I agree the part-of-speech label colours could use some tweaking however.

Haha, there's no particular reason other than it's closer to the older colour scheme which I am used to. I didn't know you were going for a new look for the rebrand.
Since you said you prefer blue, I picked #6d94bc #33719a for the entries, #3c5269 for the highlighted box. Is it better?

10t blue

I wonder if you could let us customise the colours in settings if it isn't too much work. I am used to the purple colour scheme and #1d1a19 is still a bit too light for my taste.

@birtles
Copy link
Member

birtles commented Jul 26, 2021

Haha, there's no particular reason other than it's closer to the older colour scheme which I am used to. I didn't know you were going for a new look for the rebrand.
Since you said you prefer blue, I picked #6d94bc #33719a for the entries, #3c5269 for the highlighted box. Is it better?

Thank you once again! Sorry for my delay in responding. I quite like those colours. I wonder if anyone else on this thread has a preference of the more subdued blue than the current light blue?

I wonder if you could let us customise the colours in settings if it isn't too much work. I am used to the purple colour scheme and #1d1a19 is still a bit too light for my taste.

Just to check are you referring to #1d1a19 as used in the latest version (1.1.4)? It should be almost indistinguishable from #141211 as per your screenshot.

I'd rather not make the colours customisable if we can help it since it makes maintaining the add-on harder (e.g. if we need to add a new highlight of some kind we either need to introduce new values to customise or if we try re-using existing colours we end up with the possibility of a user's custom colours making the content unreadable).

@Tomalak
Copy link

Tomalak commented Jul 26, 2021

I'm in favor of the toned-down blue. (GitHub needs a voting system)

@birtles
Copy link
Member

birtles commented Jul 27, 2021

I went to switch to the toned-down blue (#6d94bc) today but on my screen it's quite hard to read. It looks great in the screenshots above but the particular dpi/font settings on this machine means the strokes are thinner and the toned-down blue is quite hard to read.

I took that blue (#6d94bc) and the current blue (#11bbff) and put them in Eric Meyer's colour blender to get the midpoint between them: #3fa8de (https://meyerweb.com/eric/tools/color-blend/#6D94BC:11BBFF:1:hex). That for me is just barely readable without strain.

I tried going lower, e.g. 1/3 if the distance between the toned-down blue and the current blue, but I have to strain my eyes to read it.

I hope you don't mind if I go with #3fa8de for now. Obviously we can continue to tweak it as we go.

birtles added a commit that referenced this issue Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants