-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark theme with higher contrast please #692
Comments
Yeah, I came here to ask the same thing. Older dark theme was a lot easier on the eyes and blended better with my browser theme. |
Thanks for the feedback! That's good to know. Let me try tweaking it tomorrow. Thanks again! |
For me the update is a little too "neon" but I don't regularly use dark mode so I'm not sure. It looks like dark mode users tend to prefer very high contrast so maybe it's ok? |
I'm going to go ahead and release this for now. We can tweak it again if there is more feedback. |
This is now released as version 1.1.4. I've only released on Firefox for now simply because it's faster and easier than the other platforms. I'll wait to address some of the other regressions before re-releasing on the other platforms. |
I'm closing this issue but please feel free to leave feedback here, positive or negative. I'm more than happy to re-open this. |
Thank you so much for doing this and even for providing the specific hex codes! I'm curious about the purple colour. I've gone with blue because it is one of the 10ten brand colours and it is also the highlight colour used in Firefox's dark theme: Is there a reason to prefer purple? I've also gone with I agree the part-of-speech label colours could use some tweaking however. |
Haha, there's no particular reason other than it's closer to the older colour scheme which I am used to. I didn't know you were going for a new look for the rebrand. I wonder if you could let us customise the colours in settings if it isn't too much work. I am used to the purple colour scheme and |
Thank you once again! Sorry for my delay in responding. I quite like those colours. I wonder if anyone else on this thread has a preference of the more subdued blue than the current light blue?
Just to check are you referring to I'd rather not make the colours customisable if we can help it since it makes maintaining the add-on harder (e.g. if we need to add a new highlight of some kind we either need to introduce new values to customise or if we try re-using existing colours we end up with the possibility of a user's custom colours making the content unreadable). |
I'm in favor of the toned-down blue. (GitHub needs a voting system) |
I went to switch to the toned-down blue ( I took that blue ( I tried going lower, e.g. 1/3 if the distance between the toned-down blue and the current blue, but I have to strain my eyes to read it. I hope you don't mind if I go with |
I dislike the new dark theme. The contrast is too low compared with what I am used to. Could you add the old dark theme back please?
The text was updated successfully, but these errors were encountered: