Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't recognize the masu term of irregular verb いらっしゃる #303

Closed
SaltfishAmi opened this issue Jun 18, 2020 · 1 comment
Closed

Comments

@SaltfishAmi
Copy link
Contributor

いらっしゃる and いらっしゃらない can be correctly recognized, but in いらっしゃいます it will only recognize いらっしゃい as "welcome", but not the masu term of いらっしゃる.

The same for 仰(おっしゃ)る and おっしゃいます.

Maybe I'll dig into deinflect.ts and create a pr in a few days, but don't count on me...

@birtles
Copy link
Member

birtles commented Jun 19, 2020

Yeah, we should do this. I really should just re-write deinflect.js as a separate module anyway and make it easier to maintain. It's pretty horrible the way it's currently set up and I recently regressed it badly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants