Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Puck selects text even if not in overlapping position #1403

Closed
SaltfishAmi opened this issue Oct 28, 2023 · 0 comments · Fixed by #1455
Closed

Puck selects text even if not in overlapping position #1403

SaltfishAmi opened this issue Oct 28, 2023 · 0 comments · Fixed by #1455

Comments

@SaltfishAmi
Copy link
Contributor

image

Device: Microsoft Surface Laptop Studio w/ 10-point capacitative touchscreen

OS: Windows 10 Version 22H2 x64

Browser: Firefox (latest version)

Website: https://pastebin.com
@birtles birtles mentioned this issue Nov 25, 2023
Merged
birtles added a commit that referenced this issue Nov 25, 2023
@birtles
fix: check that the cursor is inside a textarea
5c5ec62 
Minimal test case:

```html
<!doctype html>
<html>
<head>
<meta charset=utf-8>
<style type="text/css">
.container {
  margin: 0 auto;
  max-width: 1340px;
}
.textarea {
  display: block;
  width: 100%;
  height: 300px;
}
</style>
</head>
<body>
  <div class="container">
    <textarea class="textarea">テスト</textarea>
  </div>
</html>
```

As for the updated title for one of the existing test cases, this
hopefully reflects what it was originally introduced to test here:

06797fa

Fixes #1403.
birtles added a commit that referenced this issue Nov 25, 2023
@birtles
fix: check that the cursor is inside a textarea
b9525ec 
Minimal test case:

```html
<!doctype html>
<html>
<head>
<meta charset=utf-8>
<style type="text/css">
.container {
  margin: 0 auto;
  max-width: 1340px;
}
.textarea {
  display: block;
  width: 100%;
  height: 300px;
}
</style>
</head>
<body>
  <div class="container">
    <textarea class="textarea">テスト</textarea>
  </div>
</html>
```

As for the updated title for one of the existing test cases, this
hopefully reflects what it was originally introduced to test here:

06797fa

Fixes #1403.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: check that the cursor is inside a textarea birchill/10ten-ja-reader
1 participant
@SaltfishAmi