Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text is no longer highlighted #1297

Closed
Brawl345 opened this issue Sep 2, 2023 · 4 comments · Fixed by #1298
Closed

Text is no longer highlighted #1297

Brawl345 opened this issue Sep 2, 2023 · 4 comments · Fixed by #1298

Comments

@Brawl345
Copy link

Brawl345 commented Sep 2, 2023

Thanks for 10ten reader, been using it for three years now!

Since the last update (I think?) the "text highlighting style" setting no longer works. The popup is still shown but the text is no longer highlighted. Using Chrome 116 on macOS, but it also doesn't work in Chrome Canary.

Example:
image

Here "台風" should be highlighted, but it isn't. I also have these settings, don't know if they are relevant:

image image
@birtles
Copy link
Member

birtles commented Sep 2, 2023

Hi! Thanks for reporting this. That sounds very bad.

I made a small change to highlighting just before releasing the latest version to fix highlight styles on pages with strict CSP settings but I guess I didn't test Chrome properly.

I'm away from my computer now but can I ask:

  1. Does this happen on all websites?
  2. Are there any error messages in the JavaScript console, e.g. CSP errors?

Thank you and sorry for the inconvenience!

@Brawl345
Copy link
Author

Brawl345 commented Sep 2, 2023

No problem! After highlighting it shows this in the console:

Denying load of chrome-extension://pnmaklegiibbioifkmfkgpfnmdehdfan/css/selection.css. Resources must be listed in the web_accessible_resources manifest key in order to be loaded by pages outside the extension.

GET chrome-extension://invalid/ net::ERR_FAILED
ensureHighlightStyles @ 10ten-ja-content.js:10104
highlightRegularNode @ 10ten-ja-content.js:10075
highlight @ 10ten-ja-content.js:9901
highlightText @ 10ten-ja-content.js:11595
highlightTextForCurrentResult @ 10ten-ja-content.js:11829
applyQueryResult @ 10ten-ja-content.js:11782
lookupText @ 10ten-ja-content.js:11737
await in lookupText (async)
tryToUpdatePopup @ 10ten-ja-content.js:11690
onPointerMove @ 10ten-ja-content.js:10877
image

I don't know if it happens everywhere, but it happens on e.g. NHK, Mainichi Shinbun, Asahi Shinbun, Wikipedia, ... Only thing not affected is text input though:

image

@birtles
Copy link
Member

birtles commented Sep 2, 2023

Perfect! Thank you so much! That's a very helpful error message. I'll get on to fixing it once I can get to a computer. Thank you again!

@birtles
Copy link
Member

birtles commented Sep 3, 2023

I've submitted a fix to the Chrome extension store but it might be a couple of days before it is approved. Thanks for reporting this and sorry for the trouble!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants