Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not working well on headlines from Yahoo News pickup pages #1033

Closed
nicolasmaia opened this issue Dec 18, 2022 · 1 comment
Closed

Not working well on headlines from Yahoo News pickup pages #1033

nicolasmaia opened this issue Dec 18, 2022 · 1 comment

Comments

@nicolasmaia
Copy link

See, for example, https://news.yahoo.co.jp/pickup/6448018
@birtles
Copy link
Member

birtles commented Dec 18, 2022

Thanks! Looks to be an issue with the <span> that wraps the headline setting font-size: 0 meaning the element gets treated as having a 0x0 bounding box which is probably tripping up our code which checks if the element is visible or not.

birtles added a commit that referenced this issue Apr 17, 2023
@birtles
fix: overhaul text lookup
ad46955 
Completely overhaul text lookup to cover more cases and (hopefully) be
easier to extend in future (so we can tackle #1130).

Fixes #990.
Fixes #1033.

Also improves performance and allows looking up `user-select: all` text
in Firefox.
birtles added a commit that referenced this issue Apr 17, 2023
@birtles
fix: overhaul text lookup
4b7c3a0 
Completely overhaul text lookup to cover more cases and (hopefully) be
easier to extend in future (so we can tackle #1130).

Fixes #990.
Fixes #1033.

Also improves performance and allows looking up `user-select: all` text
in Firefox.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@birtles @nicolasmaia