Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin node version to LTS #12

Merged
merged 1 commit into from
Oct 19, 2024
Merged

Pin node version to LTS #12

merged 1 commit into from
Oct 19, 2024

Conversation

sterliakov
Copy link
Contributor

Closes #11

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ematipico ematipico merged commit 55e628c into biomejs:main Oct 19, 2024
@asottile
Copy link

generally hooks should not make the decision of language_version unless absolutely necessary. this changes the default to download a whole copy of node unnecessarily (even when an appropriate one is available)

I would recommend reverting this. it seems #16 is related

@sterliakov
Copy link
Contributor Author

@asottile according to the tracker, the upstream bug should be fixed and released now? If so, I'll check & open a revert PR for this tomorrow - this pin was introduced as a response to broken node 23.0.0 release.

@asottile
Copy link

this shouldn't have happened here anyway. users should have overridden via default_language_version (or language_version) if desired rather than making the choice for them here

flying-sheep added a commit to flying-sheep/pre-commit that referenced this pull request Dec 17, 2024
ematipico pushed a commit that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pin node version
3 participants