Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(ja): translate Getting Started into Japanese #940

Merged
merged 5 commits into from
Nov 28, 2023
Merged

docs(ja): translate Getting Started into Japanese #940

merged 5 commits into from
Nov 28, 2023

Conversation

Yuiki
Copy link
Contributor

@Yuiki Yuiki commented Nov 28, 2023

Summary

Partial work of #880

Test Plan

  • Manually test if it is translated into Japanese in the local environment

@Yuiki Yuiki requested a review from a team as a code owner November 28, 2023 13:57
@github-actions github-actions bot added the A-Website Area: website label Nov 28, 2023
unvalley
unvalley approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@unvalley unvalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I left some nits suggestions:)

@Yuiki
Copy link
Contributor Author

Yuiki commented Nov 28, 2023

@unvalley
Thank you for your review. I committed your suggested changes.

@Yuiki Yuiki changed the title doc(ja): translate Getting Started into Japanese docs(ja): translate Getting Started into Japanese Nov 28, 2023
@unvalley unvalley merged commit 3bfcb60 into biomejs:main Nov 28, 2023
@Yuiki Yuiki deleted the ja-get-started branch November 28, 2023 16:09
@nissy-dev nissy-dev mentioned this pull request Nov 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unvalley unvalley unvalley approved these changes

Assignees
No one assigned
Labels
A-Website Area: website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yuiki @unvalley