fix(biome_console): fix printing emojis consisting of multiple codepoints #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonxabris
changed the title
|
I see from the test run the that windows character replacement stuff is not working fully, I'll try to figure out something there! |
ematipico
approved these changes
Nov 10, 2023
| /// Determines if a unicode grapheme consists only of code points | ||
| /// which are considered whitepsace characters in ASCII | ||
| fn grapheme_is_whitespace(grapheme: &str) -> bool { | ||
| grapheme.chars().all(|c| c.is_whitespace()) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #455
The source of the bug was, that the code used the
.chars()iterator, which creates Unicode code point chunks. Some complex unicode characters, like emojis can consist of multiple code points, which the code did not handle correctly. As suggested in the PR (and the conclusion I came to as well), I used theunicode_segmentationlibrary, to be able to iterate over graphemes (which is basically a character as perceived by humans). This fixes the error by treating multiple code points representing a single character as one unit.Test Plan
I've added a new test where the input string contains emojis that the CLI couldn't print before, and I'm basically asserting that the output is the exact same as the input.