Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: upgrade toolchain to Rust 1.85.0 #5225

Merged
merged 2 commits into from
Mar 1, 2025
Merged

build: upgrade toolchain to Rust 1.85.0 #5225

merged 2 commits into from
Mar 1, 2025

Conversation

siketyan
Copy link
Member

@siketyan siketyan commented Mar 1, 2025

Summary

Part of #5196

Rust 2024 is supported since Rust 1.85.0, so we need to upgrade the toolchain first.

Test Plan

Existing tests should pass.

@siketyan siketyan requested review from a team March 1, 2025 11:12
@siketyan siketyan self-assigned this Mar 1, 2025
@github-actions github-actions bot added A-Project Area: project A-Linter Area: linter A-Parser Area: parser A-Formatter Area: formatter A-Tooling Area: internal tools L-JavaScript Language: JavaScript and super languages L-Grit Language: GritQL labels Mar 1, 2025
ematipico
ematipico approved these changes Mar 1, 2025
View reviewed changes
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Feel free to merge once CI is green

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Mar 1, 2025

CodSpeed Performance Report

Merging #5225 will improve performances by 6.34%

Comparing siketyan:build/rust-1.85 (9d6348f) with main (8d9d282)

Summary

⚡ 1 improvements
✅ 96 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ react.production.min_3378072959512366797.js[cached] 2 ms 1.9 ms +6.34%

@siketyan siketyan merged commit c60ef4a into biomejs:main Mar 1, 2025
14 checks passed
@siketyan siketyan deleted the build/rust-1.85 branch March 1, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ematipico ematipico ematipico approved these changes

Assignees

@siketyan siketyan

Labels
A-Formatter Area: formatter A-Linter Area: linter A-Parser Area: parser A-Project Area: project A-Tooling Area: internal tools L-Grit Language: GritQL L-JavaScript Language: JavaScript and super languages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siketyan @ematipico