fix(lint): add missing domain to next.js rules

[Jayllyz]

Summary

Closes #5045

Test Plan

CI

[ematipico]

Good catch! However, this is a new feature that we haven't released yet, so having a fix changeset doesn't make sense :)

Could you add a new CLI test to prevent this regression?

[Jayllyz]

Good catch! However, this is a new feature that we haven't released yet, so having a fix changeset doesn't make sense :)

Ok, I'll remove it.

Could you add a new CLI test to prevent this regression?

I'm sorry, I don't understand what exactly I need to test.

[ematipico]

I'm sorry, I don't understand what exactly I need to test.

So, the nice thing of domains is that Biome can enable a rule automatically by checking the dependencies of a package.json project. So, in this PR should we recommend: true these rules, and they will be automatically enabled only if the project has next in its dependencies.

Then, we can create a CLI test like this one:

biome/crates/biome_cli/tests/cases/rules_via_dependencies.rs

Lines 10 to 54 in 3868597

	#[test]
	fn enables_react_rules_via_dependencies() {
	let mut console = BufferConsole::default();
	let mut fs = MemoryFileSystem::default();
	let file_path = Utf8Path::new("package.json");
	fs.insert(
	file_path.into(),
	r#"{
	"dependencies": {
	"react": "^16.0.0"
	}
	}
	"#
	.as_bytes(),
	);
	let content = r#"
	import { useCallback } from "react";
	function Component2() {
	const [local,SetLocal] = useState(0);
	const handle = useCallback(() => {
	console.log(local);
	}, [local, local]);
	}
	"#;
	let test = Utf8Path::new("test.jsx");
	fs.insert(test.into(), content.as_bytes());
	let (fs, result) = run_cli(
	fs,
	&mut console,
	Args::from(["lint", test.as_str()].as_slice()),
	);
	assert!(result.is_err(), "run_cli returned {result:?}");
	assert_cli_snapshot(SnapshotPayload::new(
	module_path!(),
	"enables_react_rules_via_dependencies",
	fs,
	console,
	result,
	));
	}

We put next as a dependency, and we add some file that violates one of the rules you're updating. The snapshot should contain a diagnostic of the lint rule we're testing.

[codspeed-hq]

CodSpeed Performance Report

Merging #5046 will not alter performance

_{Comparing Jayllyz:fix/missing-next-domain (81a6d2e) with next (2696970)}

Summary

✅ 94 untouched benchmarks

[Jayllyz]

I've pushed the new Next.js test, I can't find out why the rules aren't activated, if I create a biome.json that manually activates the rule, it works.

[ematipico]

@Jayllyz did you run just gen-analyzers? There's some codegen that is involved with the runtime of the rules. That's probably why it isn't working.

[Jayllyz]

@Jayllyz did you run just gen-analyzers? There's some codegen that is involved with the runtime of the rules. That's probably why it isn't working.

Oh yes forgot the codegen, i jst did just gen-all and still the generated snapshot don't detect the error and it also broke one more test (enables_all_rules_when_group_is_error).

[ematipico]

Thank you @Jayllyz, I'll look into it. Just so I understand, what's the expected rule to be triggered by your test?

[Jayllyz]

Thank you @Jayllyz, I'll look into it. Just so I understand, what's the expected rule to be triggered by your test?

This one https://biomejs.dev/linter/rules/no-img-element

[ematipico]

@Jayllyz I fixed the problem. The original rule doesn't have any Severity, this means that its default severity is Information, which doesn't emit any error. I changed is_err to is_ok (same as the other tests 😛 ). It passes now

[ematipico]

Found the bug!