-
-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(js-api): fix type definition for IFileFeaturesResult #5040
Conversation
c283816
to
149f011
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the code gen files are missing
149f011
to
5037160
Compare
The generated files aren't there on |
You should see that the code gen CI is failing :) that's the file I was referring to |
5037160
to
86fe6b2
Compare
Ah of course. Should be fixed now. |
CodSpeed Performance ReportMerging #5040 will not alter performanceComparing Summary
|
86fe6b2
to
dd28d5b
Compare
Summary
This is a quick and dirty hack to fix the type definition for this type when we generate the type definitions for the js api.
serde_wasm_bindgen
indicates this is the correct type in this table here: https://github.com/RReverser/serde-wasm-bindgen?tab=readme-ov-file#supported-typesTest Plan
It builds and generates the correct code in
packages/@biomejs/wasm-web/biome_wasm.d.ts