Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js-api): fix type definition for IFileFeaturesResult #5040

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

dyc3
Copy link
Contributor

@dyc3 dyc3 commented Feb 5, 2025

Summary

This is a quick and dirty hack to fix the type definition for this type when we generate the type definitions for the js api.

serde_wasm_bindgen indicates this is the correct type in this table here: https://github.com/RReverser/serde-wasm-bindgen?tab=readme-ov-file#supported-types

Test Plan

It builds and generates the correct code in packages/@biomejs/wasm-web/biome_wasm.d.ts

@github-actions github-actions bot added the A-Project Area: project label Feb 5, 2025
@dyc3 dyc3 force-pushed the fix-generated-type-hashmap branch from c283816 to 149f011 Compare February 5, 2025 14:04
@dyc3 dyc3 marked this pull request as ready for review February 5, 2025 14:05
@dyc3 dyc3 requested review from a team February 5, 2025 14:05
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the code gen files are missing

packages/@biomejs/wasm-web/package.json Outdated Show resolved Hide resolved
@dyc3 dyc3 force-pushed the fix-generated-type-hashmap branch from 149f011 to 5037160 Compare February 5, 2025 14:22
@dyc3
Copy link
Contributor Author

dyc3 commented Feb 5, 2025

The generated files aren't there on main or next: https://github.com/biomejs/biome/tree/main/packages/%40biomejs/wasm-web

@ematipico
Copy link
Member

ematipico commented Feb 5, 2025

You should see that the code gen CI is failing :) that's the file I was referring to

@dyc3 dyc3 force-pushed the fix-generated-type-hashmap branch from 5037160 to 86fe6b2 Compare February 5, 2025 14:39
@github-actions github-actions bot added the A-Tooling Area: internal tools label Feb 5, 2025
@dyc3
Copy link
Contributor Author

dyc3 commented Feb 5, 2025

Ah of course. Should be fixed now.

Copy link

codspeed-hq bot commented Feb 5, 2025

CodSpeed Performance Report

Merging #5040 will not alter performance

Comparing fix-generated-type-hashmap (dd28d5b) with next (a17ca7d)

Summary

✅ 94 untouched benchmarks

@dyc3 dyc3 force-pushed the fix-generated-type-hashmap branch from 86fe6b2 to dd28d5b Compare February 5, 2025 15:00
@dyc3 dyc3 merged commit 71c825e into next Feb 5, 2025
12 checks passed
@dyc3 dyc3 deleted the fix-generated-type-hashmap branch February 5, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Project Area: project A-Tooling Area: internal tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants