Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add GritQL formatting options #4824

Merged
merged 2 commits into from
Jan 2, 2025
Merged

Conversation

ematipico
Copy link
Member

Summary

Part of #2476

It adds the grit field in the Biome configuration.

Plus, I updated all our CLI test suites to use .as_str() when passing file paths. Since we use camino for paths, we don't need a OsString conversion anymore.

Test Plan

I added a test with overrides, which should cover:

  • apply the settings to a grit file
  • override settings coming from the parent formatter

@github-actions github-actions bot added A-CLI Area: CLI A-Project Area: project A-Linter Area: linter L-JavaScript Language: JavaScript and super languages A-Diagnostic Area: diagnostocis labels Jan 2, 2025
@ematipico ematipico requested review from a team January 2, 2025 10:56
Copy link

codspeed-hq bot commented Jan 2, 2025

CodSpeed Performance Report

Merging #4824 will not alter performance

Comparing feat/add-grit-language-options (10c9750) with next (d3b7b2d)

Summary

✅ 97 untouched benchmarks

@ematipico ematipico merged commit 17cf8f7 into next Jan 2, 2025
12 checks passed
@ematipico ematipico deleted the feat/add-grit-language-options branch January 2, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CLI Area: CLI A-Diagnostic Area: diagnostocis A-Linter Area: linter A-Project Area: project L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant