Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move useWhile to complexity #4777

Merged
merged 1 commit into from
Dec 23, 2024
Merged

feat: move useWhile to complexity #4777

merged 1 commit into from
Dec 23, 2024

Conversation

ematipico
Copy link
Member

Summary

Closes #4776

Test Plan

Added migration with tests

@github-actions github-actions bot added A-CLI Area: CLI A-Project Area: project A-Linter Area: linter L-JavaScript Language: JavaScript and super languages A-Diagnostic Area: diagnostocis labels Dec 22, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 22, 2024

CodSpeed Performance Report

Merging #4777 will degrade performances by 6.46%

Comparing refactor/move-use-while (dff56ee) with next (1907096)

Summary

❌ 1 regressions
✅ 96 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark next refactor/move-use-while Change
❌ react.production.min_3378072959512366797.js[cached] 1.8 ms 2 ms -6.46%

@ematipico ematipico merged commit 4f4cafb into next Dec 23, 2024
11 of 12 checks passed
@ematipico ematipico deleted the refactor/move-use-while branch December 23, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-CLI Area: CLI A-Diagnostic Area: diagnostocis A-Linter Area: linter A-Project Area: project L-JavaScript Language: JavaScript and super languages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ematipico