Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(useExplicitType): implement support for methods and functions wi… #4535

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

kaykdm
Copy link
Contributor

@kaykdm kaykdm commented Nov 14, 2024

…thout return types in interfaces, abstract classes, and modules

Summary

related: #2017
discussed here: #4463 (comment)

I've added support for methods and functions in interfaces, abstract classes, and modules:

  • TsMethodSignatureTypeMember
  • TsCallSignatureTypeMember
  • TsMethodSignatureClassMember
  • TsGetterSignatureClassMember
  • TsDeclareFunctionDeclaration
  • TsDeclareFunctionExportDefaultDeclaration

Test Plan

…thout return types in interfaces, abstract classes, and modules
@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Nov 14, 2024
Copy link
Member

@Conaclos Conaclos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Conaclos Conaclos merged commit d0b6e48 into biomejs:main Nov 14, 2024
11 checks passed
Copy link

codspeed-hq bot commented Nov 14, 2024

CodSpeed Performance Report

Merging #4535 will not alter performance

Comparing kaykdm:support-more-ts-function-return (c840c35) with main (6d75a4c)

Summary

✅ 99 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants