refactor(test): better infra for formatting #2189
Merged
+3,858
−1,860
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the testing infrastructure of the formatter.
The infrastructure now uses the actual
biome.json
configuration, so we don't need to create an additional type to map the options. It was very inconvenient.On the other hand, we can't group cases anymore, so I had to breakdown those tests by creating new folders, copying the files and setting the correct configuration.
Plus, I added a new
CONTRIBUTING.md
file that explains how to set up the infrastructure of a new formatter.Test Plan
CI should pass.
Proofread the guide. https://github.com/biomejs/biome/blob/chore/better-formatter-testing/crates/biome_formatter/CONTRIBUTING.md