Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lint/noRedeclare): Allow redeclaration of type parameters in different declarations #1937

Merged
merged 3 commits into from
Feb 28, 2024

Conversation

keita-hino
Copy link
Contributor

Summary

close: #1932

I have fixed it to allow redeclaration of type parameters in different declarations.

Test Plan

Add test cases to reproduce the issue.

@github-actions github-actions bot added A-Linter Area: linter A-Parser Area: parser A-Website Area: website L-JavaScript Language: JavaScript and super languages A-Changelog Area: changelog labels Feb 28, 2024
Copy link

netlify bot commented Feb 28, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit eaef944
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/65df4e4d4778f900076bfcd1
😎 Deploy Preview https://deploy-preview-1937--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (🔴 down 4 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codspeed-hq bot commented Feb 28, 2024

CodSpeed Performance Report

Merging #1937 will improve performances by 9.95%

Comparing keita-hino:fix-no-redeclare (eaef944) with main (f73af5d)

Summary

⚡ 1 improvements
✅ 92 untouched benchmarks

Benchmarks breakdown

Benchmark main keita-hino:fix-no-redeclare Change
big5-added.json[uncached] 3.1 ms 2.8 ms +9.95%

@ematipico ematipico merged commit 016b9e6 into biomejs:main Feb 28, 2024
20 checks passed
@keita-hino keita-hino deleted the fix-no-redeclare branch February 28, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter A-Parser Area: parser A-Website Area: website L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💅 noRedeclare false positive for overloaded functions in an interface
2 participants