fix(lint/useArrowFunction): enclose with parens when needed #1527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for biomejs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
A-Linter
Conaclos
force-pushed
the
conaclos/lint/useArrowFunction/1524
branch
from
8e0d86b to
95ccfb0
Compare
CodSpeed Performance ReportMerging #1527 will not alter performanceFalling back to comparing Summary
|
ematipico
approved these changes
Jan 11, 2024
| function_expression.syntax().parent().is_some_and(|parent| { | ||
| // Copied from the implementation of `NeedsParentheses` for `JsArrowFunctionExpression` | ||
| // in the `biome_js_formatter` crate. | ||
| // TODO: Should `NeedsParentheses` be moved in `biome_js_syntax`? |
There was a problem hiding this comment.
Reply to the TODO: since the logic is the same, I think so
crates/biome_js_analyze/tests/specs/complexity/useArrowFunction/invalid.ts.snap
Outdated
Show resolved
Hide resolved
Conaclos
force-pushed
the
conaclos/lint/useArrowFunction/1524
branch
2 times, most recently
from
cf8cbd5 to
f77b526
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #1524
Test Plan
New tests dded.