-
-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ungrammar): fork ungrammar to get ready for adding new syntax #1418
Conversation
✅ Deploy Preview for biomejs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
||
biome_ungrammar is a fork of Ungrammar (https://github.com/rust-analyzer/ungrammar). | ||
Ungrammar is licensed under the MIT or Apache-2.0 License. | ||
The copyright holder of Ungrammar is Aleksey Kladov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since Ungrammar doesn't actually have a LICENSE file, this is not truly known, but they are listed as the Author in the Cargo.toml where the license is declared, so I believe it to be as accurate as possible here.
Parser conformance results onjs/262
jsx/babel
symbols/microsoft
ts/babel
ts/microsoft
|
CodSpeed Performance ReportMerging #1418 will improve performances by 9.48%Falling back to comparing Summary
Benchmarks breakdown
|
This is enough, under the Apache 2.0 license terms |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add an Apache 2.0 licence file too in this crate?
Added the license, and also updated the years to 2024 since the fork wasn't created until this year. |
Summary
See #1407 for some more information. We want to add some new syntax to Ungrammar - the tool we use for defining the syntax tree and generating all of our node types -- to support some necessary features for CSS's flexible grammar (specifically,
||
and&&
combinators).This PR just forks the current source of
ungrammar
into a new crate in this repository -biome_ungrammar
- and updates the workspace to use it instead of the public one. Changes to ungrammar will happen in future PRs.NOTE: Ungrammar has the
MIT or Apache-2.0 License
in it's Cargo.toml, but it doesn't actually include the license file. I've added a new LICENSE file to cover our fork, and mentioned that the original code was forked and was under a different license. I'm not perfectly sure if this is the appropriate way to do this, but it does retain original attribution according to the declared license from Ungrammar, and maintains our own licensing for future contributions as well.Test Plan
All of the tests and code generation should still works exactly as they did before, since this only moves the crate into the repository with no changes.