Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(css_formatter): support @page and margin at-rules #1331

Merged
merged 1 commit into from
Dec 25, 2023

Conversation

faultyserver
Copy link
Contributor

Summary

New at-rules added in #1319! In a follow-up PR, I think I'm going to start abstracting out some of the list formatting since there are a lot of nodes that use similar structures (either a separated list that gets printed compactly, or a non-separated list that preserves empty lines).

Test Plan

Added two spec tests to cover cases similar to the parser spec tests. The snapshots appear formatted correctly.

Copy link

netlify bot commented Dec 24, 2023

Deploy Preview for biomejs canceled.

Name Link
🔨 Latest commit a7e94e3
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/65889c1a54bd7a00084c16f0

@github-actions github-actions bot added A-Formatter Area: formatter L-CSS Language: CSS labels Dec 24, 2023
Copy link
Contributor

@denbezrukov denbezrukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So fast!

@faultyserver faultyserver merged commit 7c940e4 into main Dec 25, 2023
@faultyserver faultyserver deleted the faulty/css-more-at-rules branch December 25, 2023 06:02
@Conaclos Conaclos added the A-Changelog Area: changelog label Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Formatter Area: formatter L-CSS Language: CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants