fix(service): properly merge configuration for json and css #1270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for biomejs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ematipico
approved these changes
Dec 22, 2023
There was a problem hiding this comment.
Good catch!
This part is used for the extends property of the configuration. It's used to merge a property only if it's different from the default.
I haven't found a better way to handle this, unfortunately, because as you might notice, it's not sound at all! Thank you for catching this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I'll be honest, I don't entirely know what this part would get used for, but I noticed that JSON and CSS weren't part of the
MergeWithdefinition for generalConfiguration, which I think might've been affecting how overrides would get applied? But I'm not really sure. I can just tell that both json and css should be here, since they're top level keys and would need to be merged.Test Plan
I added some test cases just around configuration validity, but it seems like the only tests that actually check overrides were already functioning...so I'm even less sure of the need for this block in general.