feat(linter): add useConsistentNewBuiltin (#2540)

biomejs · Apr 24, 2024 · b3e5768 · b3e5768
1 parent db00fca
commit b3e5768
Show file tree

Hide file tree

Showing 14 changed files with 1,257 additions and 13 deletions.
diff --git a/crates/biome_cli/src/execute/migrate/eslint_any_rule_to_biome.rs b/crates/biome_cli/src/execute/migrate/eslint_any_rule_to_biome.rs
diff --git a/crates/biome_configuration/src/linter/rules.rs b/crates/biome_configuration/src/linter/rules.rs
diff --git a/crates/biome_diagnostics_categories/src/categories.rs b/crates/biome_diagnostics_categories/src/categories.rs
@@ -130,6 +130,7 @@ define_categories! {
     "lint/nursery/noUndeclaredDependencies": "https://biomejs.dev/linter/rules/no-undeclared-dependencies",
     "lint/nursery/noUnknownUnit": "https://biomejs.dev/linter/rules/no-unknown-unit",
     "lint/nursery/useBiomeSuppressionComment": "https://biomejs.dev/linter/rules/use-biome-suppression-comment",
+    "lint/nursery/useConsistentNewBuiltin": "https://biomejs.dev/linter/rules/use-consistent-new-builtin",
     "lint/nursery/useImportRestrictions": "https://biomejs.dev/linter/rules/use-import-restrictions",
     "lint/nursery/useSortedClasses": "https://biomejs.dev/linter/rules/use-sorted-classes",
     "lint/performance/noAccumulatingSpread": "https://biomejs.dev/linter/rules/no-accumulating-spread",

diff --git a/crates/biome_js_analyze/src/lint/complexity/use_regex_literals.rs b/crates/biome_js_analyze/src/lint/complexity/use_regex_literals.rs
@@ -7,12 +7,10 @@ use biome_js_factory::make::js_regex_literal_expression;
 use biome_js_semantic::SemanticModel;
 use biome_js_syntax::{
     global_identifier, static_value::StaticValue, AnyJsCallArgument, AnyJsExpression,
-    AnyJsLiteralExpression, JsCallArguments, JsCallExpression, JsComputedMemberExpression,
-    JsNewExpression, JsSyntaxKind, JsSyntaxToken,
-};
-use biome_rowan::{
-    declare_node_union, AstNode, AstSeparatedList, BatchMutationExt, SyntaxError, TokenText,
+    AnyJsLiteralExpression, JsCallArguments, JsComputedMemberExpression, JsNewOrCallExpression,
+    JsSyntaxKind, JsSyntaxToken,
 };
+use biome_rowan::{AstNode, AstSeparatedList, BatchMutationExt, SyntaxError, TokenText};
 
 use crate::{services::semantic::Semantic, JsRuleAction};
 
@@ -54,10 +52,6 @@ declare_rule! {
     }
 }
 
-declare_node_union! {
-    pub JsNewOrCallExpression = JsNewExpression | JsCallExpression
-}
-
 pub struct UseRegexLiteralsState {
     pattern: String,
     flags: Option<String>,

diff --git a/crates/biome_js_analyze/src/lint/nursery.rs b/crates/biome_js_analyze/src/lint/nursery.rs