feat(css_parser): better handling for Dimensions (#1375)

crates/biome_css_formatter/src/css/any/dimension.rs

@@ -10,6 +10,7 @@ impl FormatRule<AnyCssDimension> for FormatAnyCssDimension {
         match node {
             AnyCssDimension::CssRegularDimension(node) => node.format().fmt(f),
             AnyCssDimension::CssPercentage(node) => node.format().fmt(f),
+            AnyCssDimension::CssUnknownDimension(node) => node.format().fmt(f),
         }
     }
 }

crates/biome_css_formatter/src/css/value/mod.rs

@@ -1,8 +1,8 @@
 //! This is a generated file. Don't modify it by hand! Run 'cargo codegen formatter' to re-generate the file.
 
 pub(crate) mod number;
-pub(crate) mod percent_dimension;
 pub(crate) mod percentage;
 pub(crate) mod ratio;
 pub(crate) mod regular_dimension;
 pub(crate) mod string;
+pub(crate) mod unknown_dimension;

crates/biome_css_formatter/src/css/value/percentage.rs

@@ -6,10 +6,10 @@ pub(crate) struct FormatCssPercentage;
 impl FormatNodeRule<CssPercentage> for FormatCssPercentage {
     fn fmt_fields(&self, node: &CssPercentage, f: &mut CssFormatter) -> FormatResult<()> {
         let CssPercentageFields {
-            value,
+            value_token,
             reminder_token,
         } = node.as_fields();
 
-        write!(f, [value.format(), reminder_token.format()])
+        write!(f, [value_token.format(), reminder_token.format()])
     }
 }

crates/biome_css_formatter/src/css/value/regular_dimension.rs

@@ -1,19 +1,22 @@
-use crate::prelude::*;
+use crate::{prelude::*, utils::string_utils::FormatTokenAsLowercase};
 use biome_css_syntax::{CssRegularDimension, CssRegularDimensionFields};
 use biome_formatter::write;
 
 #[derive(Debug, Clone, Default)]
 pub(crate) struct FormatCssRegularDimension;
 impl FormatNodeRule<CssRegularDimension> for FormatCssRegularDimension {
     fn fmt_fields(&self, node: &CssRegularDimension, f: &mut CssFormatter) -> FormatResult<()> {
-        let CssRegularDimensionFields { value, unit } = node.as_fields();
+        let CssRegularDimensionFields {
+            value_token,
+            unit_token,
+        } = node.as_fields();
 
-        write!(f, [value.format()])?;
-
-        if let Ok(unit) = unit {
-            write!(f, [unit.format()])?;
-        }
-
-        Ok(())
+        write!(
+            f,
+            [
+                FormatTokenAsLowercase::from(value_token?),
+                FormatTokenAsLowercase::from(unit_token?),
+            ]
+        )
     }
 }

crates/biome_css_formatter/src/css/value/unknown_dimension.rs

@@ -0,0 +1,23 @@
+use crate::{prelude::*, utils::string_utils::FormatTokenAsLowercase};
+use biome_css_syntax::{CssUnknownDimension, CssUnknownDimensionFields};
+use biome_formatter::write;
+
+#[derive(Debug, Clone, Default)]
+pub(crate) struct FormatCssUnknownDimension;
+impl FormatNodeRule<CssUnknownDimension> for FormatCssUnknownDimension {
+    fn fmt_fields(&self, node: &CssUnknownDimension, f: &mut CssFormatter) -> FormatResult<()> {
+        let CssUnknownDimensionFields {
+            value_token,
+            unit_token,
+        } = node.as_fields();
+
+        let var_name = write!(
+            f,
+            [
+                FormatTokenAsLowercase::from(value_token?),
+                FormatTokenAsLowercase::from(unit_token?),
+            ]
+        );
+        var_name
+    }
+}

crates/biome_css_formatter/src/generated.rs

@@ -3970,43 +3970,43 @@ impl IntoFormat<CssFormatContext> for biome_css_syntax::CssRegularDimension {
         )
     }
 }
-impl FormatRule<biome_css_syntax::CssPercentDimension>
-    for crate::css::value::percent_dimension::FormatCssPercentDimension
+impl FormatRule<biome_css_syntax::CssUnknownDimension>
+    for crate::css::value::unknown_dimension::FormatCssUnknownDimension
 {
     type Context = CssFormatContext;
     #[inline(always)]
     fn fmt(
         &self,
-        node: &biome_css_syntax::CssPercentDimension,
+        node: &biome_css_syntax::CssUnknownDimension,
         f: &mut CssFormatter,
     ) -> FormatResult<()> {
-        FormatNodeRule::<biome_css_syntax::CssPercentDimension>::fmt(self, node, f)
+        FormatNodeRule::<biome_css_syntax::CssUnknownDimension>::fmt(self, node, f)
     }
 }
-impl AsFormat<CssFormatContext> for biome_css_syntax::CssPercentDimension {
+impl AsFormat<CssFormatContext> for biome_css_syntax::CssUnknownDimension {
     type Format<'a> = FormatRefWithRule<
         'a,
-        biome_css_syntax::CssPercentDimension,
-        crate::css::value::percent_dimension::FormatCssPercentDimension,
+        biome_css_syntax::CssUnknownDimension,
+        crate::css::value::unknown_dimension::FormatCssUnknownDimension,
     >;
     fn format(&self) -> Self::Format<'_> {
         #![allow(clippy::default_constructed_unit_structs)]
         FormatRefWithRule::new(
             self,
-            crate::css::value::percent_dimension::FormatCssPercentDimension::default(),
+            crate::css::value::unknown_dimension::FormatCssUnknownDimension::default(),
         )
     }
 }
-impl IntoFormat<CssFormatContext> for biome_css_syntax::CssPercentDimension {
+impl IntoFormat<CssFormatContext> for biome_css_syntax::CssUnknownDimension {
     type Format = FormatOwnedWithRule<
-        biome_css_syntax::CssPercentDimension,
-        crate::css::value::percent_dimension::FormatCssPercentDimension,
+        biome_css_syntax::CssUnknownDimension,
+        crate::css::value::unknown_dimension::FormatCssUnknownDimension,
     >;
     fn into_format(self) -> Self::Format {
         #![allow(clippy::default_constructed_unit_structs)]
         FormatOwnedWithRule::new(
             self,
-            crate::css::value::percent_dimension::FormatCssPercentDimension::default(),
+            crate::css::value::unknown_dimension::FormatCssUnknownDimension::default(),
         )
     }
 }

crates/biome_css_formatter/tests/quick_test.rs

@@ -13,8 +13,11 @@ mod language {
 // use this test check if your snippet prints as you wish, without using a snapshot
 fn quick_test() {
     let src = r#"
-
-    @container style(--responsive: true) {  }
+    div {
+        prod: fn(100px);
+        prod: --fn(100px);
+        prod: --fn--fn(100px);
+    }
 
 "#;
     let parse = parse_css(src, CssParserOptions::default());