Skip to content

Commit

Permalink
chore: run biome on more than a few directories (#2099)
Browse files Browse the repository at this point in the history
  • Loading branch information
SuperchupuDev authored Mar 14, 2024
1 parent 89939ef commit 745afc8
Show file tree
Hide file tree
Showing 25 changed files with 380 additions and 365 deletions.
6 changes: 2 additions & 4 deletions .github/workflows/ja-translation.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@ jobs:
${{ runner.os }}-
- uses: pnpm/action-setup@v3
- name: Install libraries
working-directory: website
run: pnpm i
run: pnpm --filter @biomejs/website i
- name: Run textlint
working-directory: website
run: pnpm textlint
run: pnpm --filter @biomejs/website run textlint
18 changes: 9 additions & 9 deletions .github/workflows/pull_request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -135,17 +135,17 @@ jobs:

- name: Build TypeScript code
run: |
pnpm --prefix packages/@biomejs/backend-jsonrpc i
pnpm --prefix packages/@biomejs/backend-jsonrpc run build
pnpm --prefix packages/@biomejs/js-api run build:wasm-bundler
pnpm --prefix packages/@biomejs/js-api run build:wasm-node
pnpm --prefix packages/@biomejs/js-api run build:wasm-web
pnpm --prefix packages/@biomejs/js-api i
pnpm --prefix packages/@biomejs/js-api run build
pnpm --filter @biomejs/backend-jsonrpc i
pnpm --filter @biomejs/backend-jsonrpc run build
pnpm --filter @biomejs/js-api run build:wasm-bundler
pnpm --filter @biomejs/js-api run build:wasm-node
pnpm --filter @biomejs/js-api run build:wasm-web
pnpm --filter @biomejs/js-api i
pnpm --filter @biomejs/js-api run build
- name: Run JS tests
run: |
pnpm --prefix packages/@biomejs/backend-jsonrpc test:ci
pnpm --prefix packages/@biomejs/js-api test:ci
pnpm --filter @biomejs/backend-jsonrpc run test:ci
pnpm --filter @biomejs/js-api run test:ci
documentation:
name: Documentation
Expand Down
5 changes: 2 additions & 3 deletions .github/workflows/pull_request_js.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
- name: Run Biome Format
run: |
pnpm i
pnpm run check
pnpm run ci
type-check:
name: Type-check JS Files
Expand All @@ -65,8 +65,7 @@ jobs:
- name: Build WASM module for the web
run: wasm-pack build --out-dir ../../packages/@biomejs/wasm-web --target web --scope biomedev crates/biome_wasm
- name: Install libraries
working-directory: website
run: pnpm i
run: pnpm i --filter @biomejs/website
- name: Build JS
working-directory: website
run: pnpm build:js
Expand Down
15 changes: 7 additions & 8 deletions .github/workflows/release_js_api.yml
Original file line number Diff line number Diff line change
Expand Up @@ -90,17 +90,16 @@ jobs:
- name: Compile backends
run: |
pnpm --prefix packages/@biomejs/js-api build:wasm-bundler
pnpm --prefix packages/@biomejs/js-api build:wasm-node
pnpm --prefix packages/@biomejs/js-api build:wasm-web
pnpm --prefix packages/@biomejs/backend-jsonrpc i
pnpm --prefix packages/@biomejs/backend-jsonrpc run build
pnpm --filter @biomejs/js-api run build:wasm-bundler
pnpm --filter @biomejs/js-api run build:wasm-node
pnpm --filter @biomejs/js-api run build:wasm-web
pnpm --filter @biomejs/backend-jsonrpc i
pnpm --filter @biomejs/backend-jsonrpc run build
- name: Build package
working-directory: packages/@biomejs/js-api
run: |
pnpm i
pnpm build
pnpm --filter @biomejs/js-api i
pnpm --filter @biomejs/js-api run build
- name: Upload JS API artifact
uses: actions/upload-artifact@v3
Expand Down
13 changes: 6 additions & 7 deletions .github/workflows/runtime.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,15 +41,14 @@ jobs:
- name: Install toolchain
uses: moonrepo/setup-rust@v1
- name: Install libraries
working-directory: packages/@biomejs/js-api
run: pnpm i
run: pnpm --filter @biomejs/js-api i
- name: Compile backends
run: |
pnpm --prefix packages/@biomejs/js-api build:wasm-bundler
pnpm --prefix packages/@biomejs/js-api build:wasm-node
pnpm --prefix packages/@biomejs/js-api build:wasm-web
pnpm --prefix packages/@biomejs/backend-jsonrpc i
pnpm --prefix packages/@biomejs/backend-jsonrpc run build
pnpm --filter @biomejs/js-api run build:wasm-bundler
pnpm --filter @biomejs/js-api run build:wasm-node
pnpm --filter @biomejs/js-api run build:wasm-web
pnpm --filter @biomejs/backend-jsonrpc i
pnpm --filter @biomejs/backend-jsonrpc run build
- name: CI checks
working-directory: packages/@biomejs/js-api
run: pnpm run ci
2 changes: 2 additions & 0 deletions .npmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# workaround until https://github.com/pnpm/pnpm/issues/6300 gets fixed
dedupe-peer-dependents = false
39 changes: 39 additions & 0 deletions benchmark/bench.biome.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
{
"$schema": "../packages/@biomejs/biome/configuration_schema.json",
"linter": {
"enabled": true,
"rules": {
"recommended": false,
"complexity": {
"noExtraBooleanCast": "error"
},
"correctness": {
"noArguments": "error",
"noAsyncPromiseExecutor": "error",
"noCatchAssign": "error",
"noCompareNegZero": "error",
"noDebugger": "error",
"noDelete": "error",
"noDoubleEquals": "error",
"noDuplicateParameters": "error",
"noEmptyPattern": "error",
"noFunctionAssign": "error",
"noImportAssign": "error",
"noLabelVar": "error",
"noMultipleSpacesInRegularExpressionLiterals": "error",
"noNewSymbol": "error",
"noRestrictedGlobals": "error",
"noShadowRestrictedNames": "error",
"noSparseArray": "error",
"noUnreachable": "error",
"noUnsafeNegation": "error",
"noUnusedVariables": "error",
"useValidTypeof": "error"
},
"nursery": {
"noConstAssign": "warn",
"useValidForDirection": "warn"
}
}
}
}
38 changes: 0 additions & 38 deletions benchmark/bench.rome.json

This file was deleted.

13 changes: 4 additions & 9 deletions benchmark/dprint.json
Original file line number Diff line number Diff line change
@@ -1,12 +1,7 @@
{
"incremental": false,
"typescript": {
},
"includes": ["**/*.{ts,tsx,js,jsx,cjs,mjs}"],
"excludes": [
"**/node_modules"
],
"plugins": [
"https://plugins.dprint.dev/typescript-0.77.0.wasm"
]
"typescript": {},
"includes": ["**/*.{ts,tsx,js,jsx,cjs,mjs}"],
"excludes": ["**/node_modules"],
"plugins": ["https://plugins.dprint.dev/typescript-0.77.0.wasm"]
}
28 changes: 13 additions & 15 deletions benchmark/package.json
Original file line number Diff line number Diff line change
@@ -1,17 +1,15 @@
{
"name": "benchmark",
"version": "1.0.0",
"description": "",
"main": "run.js",
"scripts": {
"test": "echo \"Error: no test specified\" && exit 1"
},
"author": "",
"license": "MIT OR Apache-2.0",
"devDependencies": {
"@mixer/parallel-prettier": "^2.0.3",
"dprint": "^0.43.0",
"eslint": "^8.54.0",
"prettier": "^3.1.0"
}
"name": "@biomejs/benchmark",
"version": "1.0.0",
"description": "",
"private": true,
"main": "run.js",
"author": "Biome Developers and Contributors",
"license": "MIT OR Apache-2.0",
"devDependencies": {
"@mixer/parallel-prettier": "^2.0.3",
"dprint": "^0.43.0",
"eslint": "^8.54.0",
"prettier": "^3.1.0"
}
}
Loading

0 comments on commit 745afc8

Please sign in to comment.