fix(lint/useExhaustiveDependencies): do not panic on TS import equal (#…

…1593)

CHANGELOG.md

@@ -57,6 +57,8 @@ Read our [guidelines for writing a good changelog entry](https://github.com/biom
 
   Contributed by @Conaclos
 
+- [useExhaustiveDependencies](https://biomejs.dev/linter/use-exhaustive-dependencies) no longer made Biome errors in code TypeScript import equal declarations ([#1194](https://github.com/biomejs/biome/issues/1194)). Contributed by @Conaclos
+
 ### Parser
 
 

crates/biome_js_analyze/src/semantic_analyzers/correctness/use_exhaustive_dependencies.rs

@@ -369,13 +369,15 @@ fn capture_needs_to_be_in_the_dependency_list(
         | AnyJsBindingDeclaration::TsDeclareFunctionExportDefaultDeclaration(_)
         | AnyJsBindingDeclaration::JsCatchDeclaration(_) => Some(capture),
 
+        // Ignore TypeScript `import <id> =`
+        AnyJsBindingDeclaration::TsImportEqualsDeclaration(_) => None,
+
         // This should be unreachable because of the test if the capture is imported
         AnyJsBindingDeclaration::JsShorthandNamedImportSpecifier(_)
         | AnyJsBindingDeclaration::JsNamedImportSpecifier(_)
         | AnyJsBindingDeclaration::JsBogusNamedImportSpecifier(_)
         | AnyJsBindingDeclaration::JsDefaultImportSpecifier(_)
-        | AnyJsBindingDeclaration::JsNamespaceImportSpecifier(_)
-        | AnyJsBindingDeclaration::TsImportEqualsDeclaration(_) => {
+        | AnyJsBindingDeclaration::JsNamespaceImportSpecifier(_) => {
             unreachable!()
         }
     }

crates/biome_js_analyze/tests/specs/correctness/useExhaustiveDependencies/issue1194.ts

@@ -0,0 +1,13 @@
+import { useMemo } from 'react';
+
+enum Foo {
+  A = 1,
+}
+
+import Foo2 = Foo;
+
+const useBad = () => {
+  useMemo(() => {
+    2 === Foo2.A;
+  }, []);
+};

crates/biome_js_analyze/tests/specs/correctness/useExhaustiveDependencies/issue1194.ts.snap

@@ -0,0 +1,22 @@
+---
+source: crates/biome_js_analyze/tests/spec_tests.rs
+expression: issue1194.ts
+---
+# Input
+```ts
+import { useMemo } from 'react';
+
+enum Foo {
+  A = 1,
+}
+
+import Foo2 = Foo;
+
+const useBad = () => {
+  useMemo(() => {
+    2 === Foo2.A;
+  }, []);
+};
+```
+
+

website/src/content/docs/internals/changelog.mdx

@@ -63,6 +63,8 @@ Read our [guidelines for writing a good changelog entry](https://github.com/biom
 
   Contributed by @Conaclos
 
+- [useExhaustiveDependencies](https://biomejs.dev/linter/use-exhaustive-dependencies) no longer made Biome errors in code TypeScript import equal declarations ([#1194](https://github.com/biomejs/biome/issues/1194)). Contributed by @Conaclos
+
 ### Parser