Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter out unhandled schemes #69

Merged
merged 1 commit into from
Jan 5, 2024
Merged

fix: filter out unhandled schemes #69

merged 1 commit into from
Jan 5, 2024

Conversation

nhedger
Copy link
Member

@nhedger nhedger commented Jan 5, 2024

This PR fixes an issue brought to our attention by @utrolig, where the extension sends error notifications to the user after showing the diff editor.

In the latest version, we slightly changed the document filter to allow formatting and linting of untitled files. In doing so, we've let unwanted schemes be passed to Biome, and in this case, it passes files with the git scheme, which Biome does not handle.

The solution here is to add additional document filters and explicitly list the schemes we support instead of leaving them unspecified.

@nhedger nhedger merged commit 790c453 into main Jan 5, 2024
3 checks passed
@nhedger nhedger deleted the fix/scheme branch January 5, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant