-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable extension for CSS files #222
Conversation
This may happen when using a new version of bun that slightly updates the format of the lockfile.
Actually, the language must also be registered here The paxckage.json file dictates which file type the extension should activate on, and the array in main.ts tells which file should be passwe to the LSP.
I'll look into this |
Totally forgot about it! Thank you |
c285b92
to
0e3f9ed
Compare
Co-authored-by: Nicolas Hedger <[email protected]>
Is there a way to disable this? Asking because we have these errors after upgrading to Biome 1.8: ![]() We are not seeing these errors on the command line. If I understand correctly, with the CLI you have to opt-in. Listing |
You can enable CSS modules parsing, or disable CSS at all until we fix the bug that affects your file |
Sorry if I'm being slow but I don't see any way to do this (disable CSS parsing)? https://biomejs.dev/reference/configuration/#css I tried this but it doesn't help, which makes sense because the error happens during parsing:
"css": {
"linter": {
"enabled": false
},
"formatter": {
"enabled": false
}
}, |
I understand I can use that to enable parsing for CSS Modules, but I don't want to do that, rather I want to disable CSS parsing altogether. I don't want Biome to run against CSS files in VS Code, like how it already doesn't do that for the CLI (because we haven't opted in). |
Sounds like what you want might be related to #97 |
I understand that, I will have to think about it and see if I can find a solution for the broader audience. One day Biome will be a full fledged LSP, so parsing should be something you always get, like the typescript language server in VSCode. |
I'm surprised that the the extension still parses CSS files even when they're excluded/ignored in the Biome config file:
"files": {
"ignore": [
"*.css"
]
}, Edit: related issue: biomejs/biome#3749 |
Summary
The PR enables the extension for CSS files.
Description
I had a couple of issues, not sure if they are relevant:
bun
updated the lock file, not sure why. I didn't add it to the commit thoughF5
, the extension didn't trigger for the CSS files. Is it expected?This feature should be released after (together) with the release of v1.8.
Related Issue
N/A
This PR closes #<issue_number>
Checklist