added a conda recipe #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't merge this yet, if you intend to. It suffers from the same nltk stopwords issue that the 0.3.1 pip installation does. I'll let you know when I've found a fix. |
wasade
requested changes
Mar 27, 2019
|
Hi @wasade, according to the nltk README, the nltk license (Apache 2.0) only applies to the nltk code and the "NLTK corpora are provided under the terms given in the README file for each corpus; all are redistributable and available for non-commercial use". There is no mention of how to treat the tokenizers. I have already included the READMEs that accompanied the original corpus and tokenizer in their subdirectories. Are you happy with that, or would you prefer me to drop a README with the above quotation in the nltk_data directory? |
wasade
approved these changes
Mar 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... if you would like it