-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export svg #218
Merged
Merged
Export svg #218
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
ada6364
adding a function that generates a SVG string from coords and NodeCoords
sjanssen2 7bb4f04
adding button to trigger export
sjanssen2 4961830
add new vendor js dependency (as used in Emperor)
sjanssen2 e979320
add GUI element for export SVG to side-panel
sjanssen2 3388929
adding new dependency
sjanssen2 aa44fdb
Merge branch 'master' into exportSVG
sjanssen2 9eac85b
Merge branch 'master' of https://github.com/biocore/empress into expo…
sjanssen2 02cb6f6
Merge branch 'exportSVG' of https://github.com/sjanssen2/empress into…
sjanssen2 da083f7
Merge branch 'exportSVG' of git://github.com/sjanssen2/empress into e…
ElDeveloper da05def
fix codestyle
sjanssen2 bfd1b7a
export line thickness
sjanssen2 6f4938e
prettier
sjanssen2 ff49d5e
prettier
sjanssen2 2991208
Merge branch 'master' of https://github.com/biocore/empress into expo…
sjanssen2 e67db76
plot nodes in generates SVG only if "show node circles" is true
sjanssen2 a8c3acb
adding first two js-tests
sjanssen2 27ca5e7
adding more tests
sjanssen2 623ffc6
using global size variable for node radius
sjanssen2 2c93b56
Merge branch 'master' of https://github.com/biocore/empress into expo…
sjanssen2 7ddd9f4
adressing suggestions from code review
sjanssen2 ae80d82
adding a function to create a SVG version for a legend
sjanssen2 f1a762e
execute legend to SVG code
sjanssen2 028c457
generate svg separately for tree and legend due to internal informati…
sjanssen2 173c2bc
prettier
sjanssen2 1c22337
Merge branch 'master' of https://github.com/biocore/empress into expo…
sjanssen2 2b8fed0
adept to new Biom table and tree format
sjanssen2 099b9c4
codestyle
sjanssen2 c8413d6
file is now "prettier"
sjanssen2 dc911b4
Merge branch 'exportSVG' of git://github.com/sjanssen2/empress into e…
ElDeveloper 726f133
Made a few minor changes
ElDeveloper 51d1c55
STY: Prettyfy
ElDeveloper a52b493
Merge pull request #1 from ElDeveloper/exportsvg-changes
sjanssen2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a heads up, after #190 is merged, this method will no longer return the proper coordinates since they will be calculated in WebGl. Maybe we can keep this method but rename it to getSvgCoords. @ElDeveloper any thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds like a good way to go 👍 . And once we do that, it might be best to draw the arcs with single splines (which are supported in SVG) instead of line segments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, we can simply draw a line for every two successive coordinates. For circular layout, if #190 is merged, we will than track if we have to draw a "normal" line or an arc. How would this method know? But I figure we should leave this issue for future development.