Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep legend color boxes a constant size, regardless of label text length #331

Closed
fedarko opened this issue Aug 15, 2020 · 0 comments · Fixed by #340
Closed

Keep legend color boxes a constant size, regardless of label text length #331

fedarko opened this issue Aug 15, 2020 · 0 comments · Fixed by #340
Assignees
@fedarko
Labels
bug

Comments

@fedarko
Copy link
Collaborator

fedarko commented Aug 15, 2020 •
edited
Loading

Currently, if a color's label is too long, its color box gets squished a bit:

image

Ideally, we'd use CSS to handle the case when the text is too long and make the legend horizontally scrollable or something. (This can probably be handled simliarly to how we added horizontal scrolling to the node names in the selection menu, since those can be e.g. 150nt sOTUs...)

Working on #299, so I think it makes sense to address this along the way.
@fedarko fedarko added the bug label Aug 15, 2020
@fedarko fedarko self-assigned this Aug 15, 2020
fedarko added a commit to fedarko/empress that referenced this issue Aug 16, 2020
@fedarko
ENH: Overhaul categ. color legends
fc8bfe4 
Closes biocore#331.

this could still use some work, both in terms of cleaning up the code
and in making long horizontal legend items cause the legend to scroll
horizontally. i can tell it's the gradient-bar display which is
breaking that -- either flex or grid seems to explode things
@fedarko fedarko mentioned this issue Aug 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fedarko fedarko

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor and test legend code; show barplot legends fedarko/empress
1 participant
@fedarko