add bwa-mem2 #23102
add bwa-mem2 #23102
Conversation
|
@BiocondaBot update |
recipes/bwamem2/meta.yaml
Outdated
| version: {{ version }} | ||
|
|
||
| source: | ||
| url: https://github.com/bwa-mem2/bwa-mem2/releases/download/v2.0/bwa-mem2-{{ version }}_x64-linux.tar.bz2 |
There was a problem hiding this comment.
Can we please compile from source?
There was a problem hiding this comment.
These binaries were compiled with the Intel compiler and runs faster than gcc-compiled binaries. The precompiled binaries also indirectly support CPU dispatch.
I see ...
There was a problem hiding this comment.
I wasn't sure what to do about that... I guess using their binaries is preferable in this case?
|
@bgruening can you help with compiling this? I tried following these steps (with no success): I have limited experience with cpp and Makefiles and I am not sure how/where I should insert zlib. |
|
Plus I am not entirely sure how to proceed with the precompiled binaries. What would be the preferred way? For linux use precompiled and for osx compile? |
|
@BiocondaBot please add label |
|
@BiocondaBot, please fetch artifacts |
|
Package(s) built on CircleCI are ready for inspection:
You may also use
Docker image(s) built:
|
| # /Applications/Xcode-9.4.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/usr/include/string.h:145:9: note: previous declaration is here | ||
| # errno_t memset_s(void *__s, rsize_t __smax, int __c, rsize_t __n) __OSX_AVAILABLE_STARTING(__MAC_10_9, __IPHONE_7_0); | ||
| # Cause: https://github.com/intel/safestringlib/issues/14 | ||
| skip: True # [osx] |
There was a problem hiding this comment.
If someone wants to try to patch things to make it compile under macOS, feel free to do so! (Preferably in a subsequent PR ;).
|
Thanks, @mbargull and @bgruening for stepping in :). I think I was in over my head on this one. @bioconda-bot please merge |
|
Well, you took the initiative, so thanks to you too :). |
|
@BiocondaBot, please merge |
|
I will attempt to upload artifacts and merge this PR. This may take some time, please have patience. |
|
Ah good to know :) |
Describe your pull request here
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
@BiocondaBot please add labelcommand.@bioconda/corein a comment.Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update@BiocondaBot please add labelplease review & mergelabel.@BiocondaBot please fetch artifactsYou can use this to test packages locally.
For members of the Bioconda project, the following command is also available:
@BiocondaBot please mergeSomeone must approve a PR first!
This reduces CI build time by reusing built artifacts.
Also, the bot watches for comments from non-members that include
@bioconda/<team>and will automatically re-post them to notify the addressed<team>.