Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement | Prevent credentials command from overriding already configured values #77

Merged
merged 5 commits into from
Dec 23, 2021
Merged

Enhancement | Prevent credentials command from overriding already configured values #77

merged 5 commits into from
Dec 23, 2021

Conversation

angelofenoglio
Copy link
Contributor

What?

  • Updated accounts information obtained by the credential command will no longer be impacted via templates rendering. A more chirurgical approach will be used through the hcledit tool.

Why?

  • This will preserve any already configured data instead of re writing the file to a state similar to its original one.

@angelofenoglio angelofenoglio added enhancement New feature or request minor labels Dec 23, 2021
@angelofenoglio angelofenoglio added this to the 2021 Q4 milestone Dec 23, 2021
@angelofenoglio angelofenoglio self-assigned this Dec 23, 2021
@angelofenoglio angelofenoglio merged commit 001b707 into master Dec 23, 2021
@angelofenoglio angelofenoglio deleted the enhancement/prevent_credentials_command_from_overriding_config_values branch December 23, 2021 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exequielrafaela exequielrafaela exequielrafaela approved these changes

@diego-ojeda-binbash diego-ojeda-binbash Awaiting requested review from diego-ojeda-binbash

Assignees

@angelofenoglio angelofenoglio

Labels
enhancement New feature or request minor
Projects
None yet
Milestone
2021 Q4
Development

Successfully merging this pull request may close these issues.
2 participants
@angelofenoglio @exequielrafaela