Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch | Use placeholder in version #74

Merged
merged 2 commits into from
Dec 15, 2021
Merged

Patch | Use placeholder in version #74

merged 2 commits into from
Dec 15, 2021

Conversation

angelofenoglio
Copy link
Contributor

What?

  • Use placeholder for version in __init__.py instead of keeping it updated.

Why?

  • Version number is determined during packaging and tags are applied accordingly to the code. It's not necessary to keep an updated version of such number in the repository itself.
  • It simplifies release process with no downside.

@angelofenoglio angelofenoglio added this to the 2021 Q4 milestone Dec 15, 2021
@angelofenoglio angelofenoglio self-assigned this Dec 15, 2021
@exequielrafaela
Copy link
Member

Nice optimization @angelofenoglio thanks!

@angelofenoglio angelofenoglio merged commit 175c996 into master Dec 15, 2021
@angelofenoglio angelofenoglio deleted the patch/use_placeholder_in_version branch December 15, 2021 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exequielrafaela exequielrafaela exequielrafaela approved these changes

@diego-ojeda-binbash diego-ojeda-binbash Awaiting requested review from diego-ojeda-binbash

Assignees

@angelofenoglio angelofenoglio

Labels
minor
Projects
None yet
Milestone
2021 Q4
Development

Successfully merging this pull request may close these issues.
2 participants
@angelofenoglio @exequielrafaela