Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Increase compatibiliy with podman #284

Merged
merged 2 commits into from
Sep 13, 2024
Merged

feat: Increase compatibiliy with podman #284

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94808af
Fix security option string
angelofenoglio Sep 13, 2024
494e672
Run SSO login script with `sh -c`
angelofenoglio Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions leverage/container.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ def __init__(self, client, mounts: tuple = None, env_vars: dict = None):
raise Exit(1)

mounts = [Mount(source=source, target=target, type="bind") for source, target in mounts] if mounts else []
self.host_config = self.client.api.create_host_config(security_opt=["label:disable"], mounts=mounts)
self.host_config = self.client.api.create_host_config(security_opt=["label=disable"], mounts=mounts)
self.container_config = {
"image": f"{self.image}:{self.image_tag}",
"command": "",
Expand Down Expand Up @@ -405,7 +405,7 @@ def get_sso_region(self):
def sso_login(self) -> int:
region = self.get_sso_region()

with CustomEntryPoint(self, ""):
with CustomEntryPoint(self, "sh -c"):
container = self._create_container(False, command=self.AWS_SSO_LOGIN_SCRIPT)

with ContainerSession(self.client, container):
Expand Down
Loading