Lower payload size threshold for stream handlers #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -108,7 +108,7 @@ async def run_remote_forward( | |||
|
|
|||
| # call RPC on remote server | |||
| size = sum(t.element_size() * t.nelement() for t in inputs) | |||
| forward_fn = _forward_stream if size > MAX_UNARY_PAYLOAD_SIZE else _forward_unary | |||
| forward_fn = _forward_stream if size > MAX_UNARY_PAYLOAD_SIZE // 2 else _forward_unary | |||
There was a problem hiding this comment.
[nit] please check how MAX_UNARY_PAYLOAD_SIZE is defined - perhaps it's best to use MAX_MESSAGE_SIZE//4?
justheuristic
approved these changes
Feb 6, 2023
borzunov
changed the title
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hotfix: we add "// 2" since hivemind==1.1.5 serializes bfloat16 tensors in float32, so they take 2x more space.