Fix logging: do not duplicate lines, enable colors in Colab #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petals.utils.logging
borzunov
commented
Dec 15, 2022
| logger = get_logger(__file__) | ||
|
|
||
| # We suppress asyncio error logs by default since they are mostly not relevant for the end user |
There was a problem hiding this comment.
Moved to petals/utils/logging.py
borzunov
changed the title
borzunov
force-pushed
the
fix-logging
branch
from
4ded681 to
ed7d300
Compare
borzunov
changed the title
borzunov
added a commit
that referenced
this pull request
Dec 16, 2022
1. Added `from petals.client import *` to `petals/__init__.py`, so you can write just that:
```python
from petals import DistributedBloomForCausalLM
```
I didn't do the same with server, since its classes are supposed to by used by `petals.cli.run_server`, not end-users. Though it's still possible to do `from petals.server.smth import smth` if necessary.
2. Fixed one more logging issue: log lines from hivemind were shown twice due to a bug in #156.
3. Removed unused `runtime.py`, since the server actually uses `hivemind.moe.Runtime`, and `runtime.py` has no significant changes comparing to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, logs contained duplicate lines in Colab, and the colors were disabled. This PR fixes it and does some refactoring of logging along the way. Now it's beautiful: