Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: strf-8606; removed unused modules "good", "good-console" #618

Merged
merged 1 commit into from
Aug 17, 2020
Merged

refactor: strf-8606; removed unused modules "good", "good-console" #618

merged 1 commit into from
Aug 17, 2020

Conversation

MaxGenash
Copy link
Contributor

What?

These modules are deprecated so should have been dropped.
They weren’t actually used:

  • we didn’t log each incoming server request;
  • everything else (e.g. 500 errors, unhandled rejections) just goes to the console.

So I just removed them.

Tickets / Documentation

https://jira.bigcommerce.com/browse/STRF-8606

@MaxGenash MaxGenash added the dependencies Pull requests that update a dependency file label Aug 17, 2020
@MaxGenash MaxGenash requested a review from a team August 17, 2020 17:27
@MaxGenash MaxGenash self-assigned this Aug 17, 2020
@junedkazi junedkazi merged commit e75cd2e into bigcommerce:master Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junedkazi junedkazi junedkazi approved these changes

Assignees

@MaxGenash MaxGenash

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxGenash @junedkazi