feat(core): CHECKOUT-4909 Pass in attributes to stylesheet #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpschz
reviewed
May 25, 2020
src/stylesheet-loader.ts
Outdated
| @@ -4,12 +4,17 @@ import BrowserSupport from './browser-support'; | |||
|
|
|||
| export interface LoadStylesheetOptions { | |||
| prepend: boolean; | |||
| attributes: StylesheetAttributes; | |||
There was a problem hiding this comment.
should this be marked as optional?
There was a problem hiding this comment.
I believe is mandatory, prepend won't serve any purpose if we don't provide actual attributes. Please see how script loader does it Script-loader#7
There was a problem hiding this comment.
I think prepend is not related to the attributes itself, but rather, where it's loaded?
There was a problem hiding this comment.
I checked Script-loader#7 but I think it's probably a typescript bug. Should be marked as optional there too, as there is code that caters for the scenario when attributes is missing.
lpschz
approved these changes
May 25, 2020
vmparra
added
ready to merge
|
@capsula4 I've addressed your comments ♻️ |
vmparra
removed
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Pass in attributes to stylesheet
Why?
To be able to pass in attributes such as
integrityandcrossoriginTesting / Proof
@bigcommerce/frontend @bigcommerce/checkout