STENCIL-3845 Unless helper #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattolson
reviewed
Sep 15, 2017
| } | ||
| } else { // non-block helper | ||
| return result; | ||
| if (!options.fn || !options.inverse) { |
There was a problem hiding this comment.
This is changing the behavior for if when fn is not passed. Instead of returning the value, we return true. Is that what we want?
There was a problem hiding this comment.
The return values is always a boolean when called from a non-block
There was a problem hiding this comment.
Is it possible to pass fn but not inverse? Should this be
options.fn = typeof options.fn === 'function' ? options.fn : () => true;
options.inverse = typeof options.inverse === 'function' ? options.inverse : () => false;
There was a problem hiding this comment.
both need to exist. If one of them is missing, is probably a bug
mattolson
approved these changes
Sep 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customers are trying to use "unless" with operators, the same way "if" works, but we have not implemented this helper.
@bigcommerce/stencil-team