feat: STRF-9705 MessageFormat errors mark as warning

bigcommerce · Mar 16, 2022 · 5375f43 · 5375f43
1 parent 12c02ff
commit 5375f43
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 8 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,8 @@
 
 ## Pending
  - bump paper-handlerbars [#x](https://github.com/bigcommerce/paper/pull/x)
+- STRF-9705 MessageFormat errors mark as warning [#x](https://github.com/bigcommerce/paper/pull/x)
+
 ## 3.0.3 (2022-03-02)
 - STRF-9658 logger accepts strings instead of objects [#270](https://github.com/bigcommerce/paper/pull/270)
 

diff --git a/lib/translator/index.js b/lib/translator/index.js
@@ -105,7 +105,7 @@ Translator.prototype.translate = function (key, parameters) {
     try {
         return this._formatFunctions[key](parameters);
     } catch (err) {
-        this._logger.error(err.message);
+        this._logger.warn(err.message);
         return '';
     }
 };
@@ -163,7 +163,7 @@ Translator.prototype._compileTemplate = function (key) {
         return formatter.compile(this._language.translations[key]);
     } catch (err) {
         if (err.name === 'SyntaxError') {
-            this._logger.error(`Language File Syntax Error: ${err.message} for key "${key}"`, err.expected);
+            this._logger.warn(`Language File Syntax Error: ${err.message} for key "${key}"`, err.expected);
             return () => '';
         }
 

diff --git a/lib/translator/transformer.js b/lib/translator/transformer.js
@@ -125,7 +125,7 @@ function flatten(translations, preferredLocales, logger = console) {
         try {
             result[locale] = flattenObject(translations[locale]);
         } catch (err) {
-            logger.error(`Failed to flatten ${locale} - Error: ${err}`);
+            logger.warn(`Failed to flatten ${locale} - Error: ${err}`);
             result[locale] = {};
         }
     }

diff --git a/spec/lib/translator.js b/spec/lib/translator.js
@@ -48,6 +48,7 @@ describe('Translator', () => {
         loggerStub = {
             log: Sinon.fake(),
             error: Sinon.fake(),
+            warn: Sinon.fake(),
         };
 
         done();
@@ -112,7 +113,7 @@ describe('Translator', () => {
         const translator = Translator.create('nl', Object.assign({}, translations, { nl: nl }), loggerStub);
 
         expect(translator.translate('bye')).to.equal('Bye bye');
-        expect(loggerStub.error.called).to.equal(true);
+        expect(loggerStub.warn.called).to.equal(true);
 
         done();
     });
@@ -130,8 +131,8 @@ describe('Translator', () => {
         const translator = Translator.create('en', translations, loggerStub);
 
         expect(translator.translate('hello')).to.equal('');
-        expect(loggerStub.error.called).to.equal(true);
-        expect(loggerStub.error.getCall(0).args[0]).to.equal("MessageFormat: Data required for 'name'.")
+        expect(loggerStub.warn.called).to.equal(true);
+        expect(loggerStub.warn.getCall(0).args[0]).to.equal("MessageFormat: Data required for 'name'.")
 
         done();
     });
@@ -146,8 +147,8 @@ describe('Translator', () => {
         const result = translator.translate('items_with_syntax_error', { count: 1 });
         const errMessage = 'Language File Syntax Error: Expected "plural" or "select" but "p" found. for key "items_with_syntax_error"';
         expect(result).to.equal("");
-        expect(loggerStub.error.called).to.equal(true);
-        expect(loggerStub.error.getCall(0).args[0]).to.equal(errMessage);
+        expect(loggerStub.warn.called).to.equal(true);
+        expect(loggerStub.warn.getCall(0).args[0]).to.equal(errMessage);
 
         done();
     });