chore(storefront): STRF-11941 Helper should just return nonce in quot…

…es (#306)
bigcommerce · May 29, 2024 · fe270f7 · fe270f7
1 parent eee9306
commit fe270f7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/helpers/nonce.js b/helpers/nonce.js
@@ -4,7 +4,7 @@ const factory = globals => {
     return function() {
         const params = globals.getRequestParams();
         if (params && params.security && params.security.nonce) {
-            return new globals.handlebars.SafeString(` nonce="${params.security.nonce}"`);
+            return new globals.handlebars.SafeString(`"${params.security.nonce}"`);
         }
         return ''
     };

diff --git a/spec/helpers/nonce.js b/spec/helpers/nonce.js
@@ -6,7 +6,7 @@ const {testRunner, buildRenderer, randomString} = require('../spec-helpers');
 describe('nonce helper', function () {
     const context = {}
 
-    it('should render a nonce html attribute with the correct value from request params', function (done) {
+    it('should render a nonce in quotes with the correct value from request params', function (done) {
         const requestParams = {
             security: {
                 nonce: randomString()
@@ -17,7 +17,7 @@ describe('nonce helper', function () {
         runTestCases([
             {
                 input: '{{nonce}}',
-                output: ' nonce="' + requestParams.security.nonce + '"',
+                output: '"' + requestParams.security.nonce + '"',
             },
         ], done);
     });